U++ framework: U++ Core » Why ReadWithBarrier returns bool (current svn)

Home » U++ Library support » U++ Core » Why ReadWithBarrier returns bool (current svn)

Tue, 06 May 2008 21:25

mirek
Messages: 14291
Registered: November 2005

Ultimate Member

hans wrote on Tue, 06 May 2008 14:31

Hi, we have

template <class U>
inline bool ReadWithBarrier(const volatile U& b)
{
	volatile bool tmp = b;
	ReadMemoryBarrier();
	return tmp;
}

but use it as it would return an int too, like in

inline int  AtomicRead(const volatile Atomic& t)      { return ReadWithBarrier(t); }

So I would suggest to replace in ReadWithBarrier the bool with the U template parameter (in tmp var and return type).

Cheers, Hans.

Yes, already done. You caught us in the process Smile

BTW, final version removes second volatile too -> leads to more optimal but still correct code on both GCC and MSC (7.1, 8, 9).

Mirek

		Why ReadWithBarrier returns bool (current svn) By: hans on Tue, 06 May 2008 20:31
		Re: Why ReadWithBarrier returns bool (current svn) By: mirek on Tue, 06 May 2008 21:25
		Re: Why ReadWithBarrier returns bool (current svn) By: tojocky on Thu, 17 September 2009 11:19

Previous Topic:	How to re-initialize random generator?
Next Topic:	U++ core app as DLL: memory manager problems?

Goto Forum:

] [

]

Current Time: Wed Oct 21 06:15:06 GMT+2 2026

Total time taken to generate the page: 0.00862 seconds