U++ forum: Welcome to the forum

Re: Postgres library improvements [message #22607 is a reply to message #22606]

Fri, 31 July 2009 10:22

mirek
Messages: 13984
Registered: November 2005

Ultimate Member

Zbych wrote on Thu, 30 July 2009 16:12

I've made some additional tests and it appears that code page and client language are one big mess in windows version of postgresql:

1. Before client is connected, error messages (for example when server is down) use win-1250 code page (environment variable LC_LOCALE is ignored, bug)

2. When client tries to connect, but connection is refused (for example when client has no right to connect to database), error messages use code page and language set in configuration of server (in my case utf-8)

3. When client is connected and code page is set by PQsetClientEncoding, error messages use correct code page.

I tried to fix the problem:

String PostgreSQLSession::ErrorMessage()
{
    if (PQclientEncoding(conn) >= 0) return PQerrorMessage(conn);
    return FromSystemCharset(PQerrorMessage(conn));
}

but it only solves case 1 i 3.

Any ideas how to handle this correctly?

For now, patch applied.

I guess that perhaps the issue is not that serious. error messages tend to be in basic ascii, especially connection messages.

Moreover, you do not expect regular users to understand them anyway...

Mirek

Report message to a moderator