U++ forum: Welcome to the forum

Re: Little problem in util.cpp and simple solution [message #35997 is a reply to message #35995]

Tue, 17 April 2012 10:03

mirek
Messages: 13984
Registered: November 2005

Ultimate Member

Zbych wrote on Tue, 17 April 2012 03:45

Removing sign bit like this:

int msecs(int from) { return int((GetTickCount() - (dword)from) & 0x7fffffff); }
                                                                ^^^^^^^^^^^^^^^^

is not a good idea. There are some places in upp that rely on sign bit (e.g. httcli):

if(msecs(end_time) >= 0) {
^^^^^^^^^^^^^^^^^^^^^^^^^^
	error = NFormat("Timeout reading footer block (%d B).", body.GetLength());
	break;
}

While in other places msecs is used incorrectly (httpcli again):

while(msecs() < end_time) {

Someone forgot that ticks wrap every ~50 days (or ~25 days if sign bit is masked).

Thanks, correct, reverted and hopefully places where wrap applies fixed (please check).

Mirek

Report message to a moderator