U++ framework: U++ Core » Little problem in util.cpp and simple solution

Home » U++ Library support » U++ Core » Little problem in util.cpp and simple solution

Show: Today's Messages :: Polls :: Message Navigator
E-mail to friend

Re: Little problem in util.cpp and simple solution [message #35997 is a reply to message #35995]

Tue, 17 April 2012 10:03

mirek
Messages: 14291
Registered: November 2005

Ultimate Member

Zbych wrote on Tue, 17 April 2012 03:45

Removing sign bit like this:

int msecs(int from) { return int((GetTickCount() - (dword)from) & 0x7fffffff); }
                                                                ^^^^^^^^^^^^^^^^

is not a good idea. There are some places in upp that rely on sign bit (e.g. httcli):

if(msecs(end_time) >= 0) {
^^^^^^^^^^^^^^^^^^^^^^^^^^
	error = NFormat("Timeout reading footer block (%d B).", body.GetLength());
	break;
}

While in other places msecs is used incorrectly (httpcli again):

while(msecs() < end_time) {

Someone forgot that ticks wrap every ~50 days (or ~25 days if sign bit is masked).

Thanks, correct, reverted and hopefully places where wrap applies fixed (please check).

Mirek

Report message to a moderator

[Message index]

		Little problem in util.cpp and simple solution By: koldo on Sun, 15 April 2012 22:16
		Re: Little problem in util.cpp and simple solution By: mirek on Mon, 16 April 2012 21:55
		Re: Little problem in util.cpp and simple solution By: Zbych on Tue, 17 April 2012 09:45
		Re: Little problem in util.cpp and simple solution By: Zbych on Tue, 17 April 2012 09:52
		Re: Little problem in util.cpp and simple solution By: mirek on Tue, 17 April 2012 10:03

Previous Topic:	LaunchWebBrowser() problem and perhaps not the best solution
Next Topic:	Jsonize problems with maps

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Mon Sep 14 16:02:01 GMT+2 2026

Total time taken to generate the page: 0.00699 seconds