Overview
Examples
Screenshots
Comparisons
Applications
Download
Documentation
Tutorials
Bazaar
Status & Roadmap
FAQ
Authors & License
Forums
Funding Ultimate++
Search on this site
Search in forums












SourceForge.net Logo
Home » Community » U++ community news and announcements » 2023.1rc1
Re: 2023.1rc1 [message #59907 is a reply to message #59906] Tue, 23 May 2023 07:52 Go to previous messageGo to next message
Tom1
Messages: 1212
Registered: March 2007
Senior Contributor
Hi,

I found that in Linux Mint Cinnamon dark theme (Mint Y Dark Aqua), the drop down menu selection coloring was fixed to use white text with dark gray selection bar, but the main menu still uses black text with dark gray selection bar. Can this be fixed to use white text too?

Best regards,

Tom

UPDATE: More: For some reason, with light themes, U++ is using the 'colorization' color for main menu selection bar, whereas all the other applications tend to use the same colors as the drop down menu. I think setting the main menu to use all the same colors as the drop down menu would be the best choice here.

[Updated on: Tue, 23 May 2023 08:02]

Report message to a moderator

Re: 2023.1rc1 [message #59908 is a reply to message #59907] Tue, 23 May 2023 09:52 Go to previous messageGo to next message
mirek is currently offline  mirek
Messages: 13975
Registered: November 2005
Ultimate Member
Tom1 wrote on Tue, 23 May 2023 07:52
Hi,

I found that in Linux Mint Cinnamon dark theme (Mint Y Dark Aqua), the drop down menu selection coloring was fixed to use white text with dark gray selection bar, but the main menu still uses black text with dark gray selection bar. Can this be fixed to use white text too?


I can you add some DDUMPS so that I know what is going on? (Installing Mint Cinnamon would take a lot of time, sorry)

Basically everything from CtrlLib/ChGtk3.cpp:525 till the end of block }.

Also, is this inactive state or when you press mouse button over it (like open the menu)?


Quote:

UPDATE: More: For some reason, with light themes, U++ is using the 'colorization' color for main menu selection bar, whereas all the other applications tend to use the same colors as the drop down menu. I think setting the main menu to use all the same colors as the drop down menu would be the best choice here.


If that was so easy... Some themes are using white text on black for top menu items and black on light for drop down...
Re: 2023.1rc1 [message #59909 is a reply to message #59908] Tue, 23 May 2023 11:02 Go to previous messageGo to next message
Tom1
Messages: 1212
Registered: March 2007
Senior Contributor
Hi Mirek,

Hope this helps...

With default light theme:
s.look = Image (32, 16)
dk = Color(48, 48, 48)
wh = Color(255, 255, 255)
After IsDark(wh):
dk = Color(48, 48, 48)
wh = Color(255, 255, 255)
s.topitemtext[0] = Color(48, 48, 48)
s.topitemtext[1] = Color(48, 48, 48)
s.topitemtext[2] = Color(33, 33, 33)
s.topitem[0] = 
s.topitem[1] = 
s.topitem[2] = Image (32, 16)
After Diff():
s.topitemtext[0] = Color(48, 48, 48)
s.topitemtext[1] = Color(48, 48, 48)
s.topitemtext[2] = Color(255, 255, 255)
s.topitem[0] = 
s.topitem[1] = 
s.topitem[2] = Color(53, 168, 84)


And dark theme:
s.look = Image (32, 16)
dk = Color(218, 218, 218)
wh = Color(64, 64, 64)
After IsDark(wh):
dk = Color(64, 64, 64)
wh = Color(218, 218, 218)
s.topitemtext[0] = Color(218, 218, 218)
s.topitemtext[1] = Color(218, 218, 218)
s.topitemtext[2] = Color(7, 7, 7)
s.topitem[0] = 
s.topitem[1] = 
s.topitem[2] = Image (32, 16)
After Diff():
s.topitemtext[0] = Color(218, 218, 218)
s.topitemtext[1] = Color(218, 218, 218)
s.topitemtext[2] = Color(7, 7, 7)
s.topitem[0] = 
s.topitem[1] = 
s.topitem[2] = Image (32, 16)


Best regards,

Tom

UPDATE: This is when I click the main menu to open a drop down. When just hovering over the top menu without clicking anything, it does not react in any way.

[Updated on: Tue, 23 May 2023 11:05]

Report message to a moderator

Re: 2023.1rc1 [message #59910 is a reply to message #59909] Tue, 23 May 2023 11:06 Go to previous messageGo to next message
mirek is currently offline  mirek
Messages: 13975
Registered: November 2005
Ultimate Member
Tom1 wrote on Tue, 23 May 2023 11:02
Hi Mirek,

Hope this helps...

With default light theme:
s.look = Image (32, 16)
dk = Color(48, 48, 48)
wh = Color(255, 255, 255)
After IsDark(wh):
dk = Color(48, 48, 48)
wh = Color(255, 255, 255)
s.topitemtext[0] = Color(48, 48, 48)
s.topitemtext[1] = Color(48, 48, 48)
s.topitemtext[2] = Color(33, 33, 33)
s.topitem[0] = 
s.topitem[1] = 
s.topitem[2] = Image (32, 16)
After Diff():
s.topitemtext[0] = Color(48, 48, 48)
s.topitemtext[1] = Color(48, 48, 48)
s.topitemtext[2] = Color(255, 255, 255)
s.topitem[0] = 
s.topitem[1] = 
s.topitem[2] = Color(53, 168, 84)


And dark theme:
s.look = Image (32, 16)
dk = Color(218, 218, 218)
wh = Color(64, 64, 64)
After IsDark(wh):
dk = Color(64, 64, 64)
wh = Color(218, 218, 218)
s.topitemtext[0] = Color(218, 218, 218)
s.topitemtext[1] = Color(218, 218, 218)
s.topitemtext[2] = Color(7, 7, 7)
s.topitem[0] = 
s.topitem[1] = 
s.topitem[2] = Image (32, 16)
After Diff():
s.topitemtext[0] = Color(218, 218, 218)
s.topitemtext[1] = Color(218, 218, 218)
s.topitemtext[2] = Color(7, 7, 7)
s.topitem[0] = 
s.topitem[1] = 
s.topitem[2] = Image (32, 16)


Best regards,

Tom


More! Smile

I need

DDUMP(AvgColor(s.topitem[2], SColorFace(), 0))
DDUMP(Diff(AvgColor(s.topitem[2], SColorFace(), 0), s.topitemtext[2]))
DDUMP(SColorHighlight())
DDUMP(SColorHighlightText())

(before })
Re: 2023.1rc1 [message #59911 is a reply to message #59910] Tue, 23 May 2023 12:04 Go to previous messageGo to next message
Tom1
Messages: 1212
Registered: March 2007
Senior Contributor
Hi,

For light theme:

AvgColor(s.topitem[2], SColorFace(), 0) = Color(0, 0, 0)
Diff(AvgColor(s.topitem[2], SColorFace(), 0), s.topitemtext[2]) = 33
SColorHighlight() = Color(53, 168, 84)
SColorHighlightText() = Color(255, 255, 255)


For dark theme:

AvgColor(s.topitem[2], SColorFace(), 0) = Color(245, 245, 245)
Diff(AvgColor(s.topitem[2], SColorFace(), 0), s.topitemtext[2]) = 238
SColorHighlight() = Color(31, 158, 222)
SColorHighlightText() = Color(255, 255, 255)



UPDATE: These are dumped just before if(Diff(...

Best regards,

Tom

[Updated on: Tue, 23 May 2023 12:06]

Report message to a moderator

Re: 2023.1rc1 [message #59912 is a reply to message #59911] Tue, 23 May 2023 12:23 Go to previous messageGo to next message
mirek is currently offline  mirek
Messages: 13975
Registered: November 2005
Ultimate Member
Tom1 wrote on Tue, 23 May 2023 12:04
Hi,

For light theme:

AvgColor(s.topitem[2], SColorFace(), 0) = Color(0, 0, 0)
Diff(AvgColor(s.topitem[2], SColorFace(), 0), s.topitemtext[2]) = 33
SColorHighlight() = Color(53, 168, 84)
SColorHighlightText() = Color(255, 255, 255)


For dark theme:

AvgColor(s.topitem[2], SColorFace(), 0) = Color(245, 245, 245)
Diff(AvgColor(s.topitem[2], SColorFace(), 0), s.topitemtext[2]) = 238
SColorHighlight() = Color(31, 158, 222)
SColorHighlightText() = Color(255, 255, 255)



UPDATE: These are dumped just before if(Diff(...

Best regards,

Tom


Weird. Can you also send screenshot (of "bad" situation)?
Re: 2023.1rc1 [message #59913 is a reply to message #59912] Tue, 23 May 2023 12:43 Go to previous messageGo to next message
Tom1
Messages: 1212
Registered: March 2007
Senior Contributor
Hi,

Here is a crappy shrinked photo attached... cannot take screenshot of the menu as it disappears! Anyway, you will get the picture.

BR, Tom
Re: 2023.1rc1 [message #59914 is a reply to message #59913] Tue, 23 May 2023 13:21 Go to previous messageGo to next message
mirek is currently offline  mirek
Messages: 13975
Registered: November 2005
Ultimate Member
Tom1 wrote on Tue, 23 May 2023 12:43
Hi,

Here is a crappy shrinked photo attached... cannot take screenshot of the menu as it disappears! Anyway, you will get the picture.

BR, Tom


OK, I guess this might be the same problem as with menu items. I have tried fix in master, can you recheck?

(Unfortunately that means rechecking manjaro etc. themes as well...)
Re: 2023.1rc1 [message #59915 is a reply to message #59914] Tue, 23 May 2023 13:51 Go to previous messageGo to next message
Tom1
Messages: 1212
Registered: March 2007
Senior Contributor
Hi,

Much better already. Smile

Now the light theme works exactly correctly, like e.g. Gnome Drawing or Libre Office. However, while the dark theme received correct main menu text color, it also now uses 'colorization' color for top menu selection bar. The two other applications above use dropdown back color for topmenu selection bar. I think that is the desired color.

Here's the current dark theme view attached.

Br, Tom
Re: 2023.1rc1 [message #59916 is a reply to message #59915] Tue, 23 May 2023 13:52 Go to previous messageGo to next message
Tom1
Messages: 1212
Registered: March 2007
Senior Contributor
And Gnome Drawing for reference...

Tom
Re: 2023.1rc1 [message #59917 is a reply to message #59916] Tue, 23 May 2023 14:05 Go to previous messageGo to next message
Tom1
Messages: 1212
Registered: March 2007
Senior Contributor
Hi,

This works here for both light and dark themes:

		s.topitemtext[2] = GetInkColor();
		Over(m, topitem);
		if(Diff(AvgColor(m), s.topitemtext[2]) < 100) {
			//s.topitem[2] = SColorHighlight(); // <<< Commenting this out helps!
			s.topitemtext[2] = SColorHighlightText();
		}
	}


Best regards,

Tom
Re: 2023.1rc1 [message #59918 is a reply to message #59917] Tue, 23 May 2023 15:22 Go to previous messageGo to next message
mirek is currently offline  mirek
Messages: 13975
Registered: November 2005
Ultimate Member
Tom1 wrote on Tue, 23 May 2023 14:05
Hi,

This works here for both light and dark themes:

		s.topitemtext[2] = GetInkColor();
		Over(m, topitem);
		if(Diff(AvgColor(m), s.topitemtext[2]) < 100) {
			//s.topitem[2] = SColorHighlight(); // <<< Commenting this out helps!
			s.topitemtext[2] = SColorHighlightText();
		}
	}


Best regards,

Tom


OK, tried to further simplify it a bit. What about master now?
Re: 2023.1rc1 [message #59919 is a reply to message #59918] Tue, 23 May 2023 15:23 Go to previous messageGo to next message
mirek is currently offline  mirek
Messages: 13975
Registered: November 2005
Ultimate Member
Also please test with theide too - that has slightly different menu styling required.
Re: 2023.1rc1 [message #59920 is a reply to message #59919] Tue, 23 May 2023 16:28 Go to previous messageGo to next message
Tom1
Messages: 1212
Registered: March 2007
Senior Contributor
mirek wrote on Tue, 23 May 2023 16:23
Also please test with theide too - that has slightly different menu styling required.

Thanks! Smile
Everything seems to work just fine here with Linux Mint and many different themes. Also with TheIDE. Is there any specific testing requirements for TheIDE, I should try?

Best regards,

Tom

Re: 2023.1rc1 [message #59921 is a reply to message #59920] Tue, 23 May 2023 17:29 Go to previous message
mirek is currently offline  mirek
Messages: 13975
Registered: November 2005
Ultimate Member
Tom1 wrote on Tue, 23 May 2023 16:28
mirek wrote on Tue, 23 May 2023 16:23
Also please test with theide too - that has slightly different menu styling required.

Thanks! Smile
Everything seems to work just fine here with Linux Mint and many different themes. Also with TheIDE.


Thanks.

Quote:

Is there any specific testing requirements for TheIDE, I should try?


No.

Mirek
Previous Topic: 2023.1 alpha
Next Topic: 2023.1rc3
Goto Forum:
  


Current Time: Sat May 04 12:02:25 CEST 2024

Total time taken to generate the page: 0.02625 seconds