Home » Community » U++ community news and announcements » U++ 2019.1.rc6 released
|
|
Re: U++ 2019.1.rc6 released [message #51714 is a reply to message #51712] |
Tue, 30 April 2019 17:03 |
Novo
Messages: 1358 Registered: December 2006
|
Ultimate Contributor |
|
|
In case of Clang version 7.0.0-3 (ubuntu 18.10) NOUBSAN is not defined.
#if __GNUC__ > 6
#define NOUBSAN __attribute__((no_sanitize_undefined))
#elif __clang__ > 6
#define NOUBSAN __attribute__((no_sanitize("undefined")))
#else
#define NOUBSAN
#endif
This is what I get for this compiler:
#define __clang__ 1
#define __clang_major__ 7
#define __clang_minor__ 0
#define __clang_patchlevel__ 0
#define __clang_version__ "7.0.0 (tags/RELEASE_700/final)"
echo . | clang++ -dM -E - | grep clang
Regards,
Novo
|
|
|
|
Re: U++ 2019.1.rc6 released [message #51716 is a reply to message #51715] |
Tue, 30 April 2019 19:49 |
Novo
Messages: 1358 Registered: December 2006
|
Ultimate Contributor |
|
|
mirek wrote on Tue, 30 April 2019 11:53__clang_major__ > 6 then?
UndefinedBehaviorSanitizer was first introduced in clang 3.8 ... So, __clang_major__ >= 4 would look better.
Clang versioning in MacOS is different, so, I do not know how it will work there.
Regards,
Novo
|
|
|
Re: U++ 2019.1.rc6 released [message #51717 is a reply to message #51716] |
Tue, 30 April 2019 20:50 |
Novo
Messages: 1358 Registered: December 2006
|
Ultimate Contributor |
|
|
#if __has_attribute(no_sanitize)
#define NOUBSAN __attribute__((no_sanitize("undefined")))
#else
#define NOUBSAN
#endif
This works with both Clang and GCC. Unsure about MSVC.
Regards,
Novo
|
|
|
Re: U++ 2019.1.rc6 released [message #51718 is a reply to message #51717] |
Tue, 30 April 2019 23:00 |
|
Klugier
Messages: 1076 Registered: September 2012 Location: Poland, Kraków
|
Senior Contributor |
|
|
Hello Mirek,
I will not create any sneaky fix into the release I have one consideration about dark theme. I think the keyword color in code editor (dark variant) is too similar to regular text. Please look at this screenshot.
I think it should be orange or something more verbose. Tom and cbpporter please help us select the best color for keywords...
Mirek, you could also think about chaining the license year from 2014 to 2019:
Copyright (c) 1998, 2014, The U++ Project
to
Copyright (c) 1998, 2019, The U++ Project
Sincerely,
Klugier
U++ - one framework to rule them all.
[Updated on: Tue, 30 April 2019 23:15] Report message to a moderator
|
|
|
|
|
Re: U++ 2019.1.rc6 released [message #51721 is a reply to message #51720] |
Wed, 01 May 2019 00:55 |
Novo
Messages: 1358 Registered: December 2006
|
Ultimate Contributor |
|
|
mirek wrote on Tue, 30 April 2019 17:26Novo wrote on Tue, 30 April 2019 20:50#if __has_attribute(no_sanitize)
#define NOUBSAN __attribute__((no_sanitize("undefined")))
#else
#define NOUBSAN
#endif
Unsure about MSVC.
Exactly. Seriously, I think > 6 is the safe bet that does not break anything.
This is up to you as long as it works with Clang ...
Regards,
Novo
|
|
|
|
Goto Forum:
Current Time: Tue May 21 19:30:48 CEST 2024
Total time taken to generate the page: 0.01560 seconds
|