U++ forum: Welcome to the forum

Search on this site

Search in forums

Home » Developing U++ » U++ Developers corner » libpng1.4

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

libpng1.4 [message #24800]

Sat, 30 January 2010 17:05

dolik.rce
Messages: 1789
Registered: August 2008
Location: Czech Republic

Ultimate Contributor

Hello all

I've just accidentally upgraded libpng from 1.2 to 1.4 (accidentally = I activated testing repository on my Arch linux Smile

). The expected result of this was, that theide stopped working, because libpng12.so was no longer available.

But there was also one unexpected result (and that's why I'm posting this): plugin/png fails to compile. The reason is that in uppsrc/plugin/png/pngupp.cpp, lines 429-431 say

#ifdef PNG_iTXt_SUPPORTED
text_ptr[0].lang = NULL;
#endif

So far this was OK, since PNG_iTXt_SUPPORTED was false by default, but as of 1.4, iTXt is enabled by default (see http://www.libpng.org/pub/png/src/libpng-1.2.x-to-1.4.x-summ ary.txt, so it fails on undefined text_ptr.

I'm not sure what is the reason or function of this, but I believe that we don't really use it Smile

Commenting these three lines solves the problem.

Could someone with commit rights change this in svn please?

Best regards,
Honza

Report message to a moderator

Re: libpng1.4 [message #25817 is a reply to message #24800]

Sat, 13 March 2010 20:48

dolik.rce
Messages: 1789
Registered: August 2008
Location: Czech Republic

Ultimate Contributor

After recent changes U++ still doesn't work with libpng1.4. The only necessary change is commenting out or deleting following in pngupp.cpp:

		#ifdef PNG_iTXt_SUPPORTED
		text_ptr[0].lang = NULL;
		#endif

Could someone do this, please? Smile

The line makes no sense there anyway...

Honza

[Updated on: Sat, 13 March 2010 20:57]

Report message to a moderator

Previous Topic:	Xmlize values
Next Topic:	Open file in already opened app instead of launching a second copy

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sat Apr 20 11:22:53 CEST 2024

Total time taken to generate the page: 0.01634 seconds