U++ framework: UppHub » [Funtions4U] Double definition of MIN

Home » Developing U++ » UppHub » [Funtions4U] Double definition of MIN

Show: Today's Messages :: Polls :: Message Navigator
E-mail to friend

[Funtions4U] Double definition of MIN [message #43306]

Fri, 27 June 2014 10:39

jibe
Messages: 294
Registered: February 2007
Location: France

Experienced Member

Hi, Koldo,

In bsdiff.cpp, there is a

#define MIN(x,y) (((x)<(y)) ? (x) : (y))

but this was already defined in /usr/include/glib-2.0/glib/gmacros.h (I'm using Linux Mint Maya, and have the same warning with Scientific Linux and CentOS. Probably the same with all Linux distros).

This is not a problem : the definition is similar. It's just causing a warning.

Probably, it's bad to remove this define, as in some case or other OS gmacros could not be included or not have this define. But probably you could add a #indef before ?

Report message to a moderator

Re: [Funtions4U] Double definition of MIN [message #43310 is a reply to message #43306]

Fri, 27 June 2014 13:07

koldo
Messages: 3460
Registered: August 2008

Senior Veteran

Hell Jibe

No problem. I have just changed it. It is only used in that .cpp file. And license permits it.

Thank you.

Best regards
Iñaki

Report message to a moderator

Re: [Funtions4U] Double definition of MIN [message #43326 is a reply to message #43310]

Mon, 30 June 2014 19:28

jibe
Messages: 294
Registered: February 2007
Location: France

Experienced Member

Hi, Koldo,

koldo wrote on Fri, 27 June 2014 13:07

And license permits it.

Ooops ! Sorry : I didn't payed attention and I was thinking that it was your own work.

koldo wrote on Fri, 27 June 2014 13:07

I have just changed it.

Yes, good ! No more warning Smile

Smile

Thanks.

Report message to a moderator

Re: [Funtions4U] Double definition of MIN [message #43332 is a reply to message #43326]

Tue, 01 July 2014 08:05

koldo
Messages: 3460
Registered: August 2008

Senior Veteran

Quote:

Ooops ! Sorry : I didn't payed attention and I was thinking that it was your own work.

Of course yes Smile

Smile

. But in this case specially because bsdiff is an external library, but with a BSD license.

Best regards
Iñaki

Report message to a moderator

Previous Topic:	Time for a little cleanup ?
Next Topic:	Zint Barcode Generator

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

PDF

]

Current Time: Mon Jun 22 03:30:38 GMT+2 2026

Total time taken to generate the page: 0.00538 seconds