U++ framework: U++ community news and announcements » Index constructor from Vector now explicit

Home » Community » U++ community news and announcements » Index constructor from Vector now explicit

Show: Today's Messages :: Polls :: Message Navigator
E-mail to friend

Index constructor from Vector now explicit [message #39196]

Tue, 26 February 2013 20:02

mirek
Messages: 14291
Registered: November 2005

Ultimate Member

Today I have encountered pretty tricky issue:

VectorMap<String, String> h;
const Index<String>& x = h.GetKeys();

This innocent looking code is broken in a very tricky way: GetKeys returns a reference to Vector<String> which is then picked by Index constructor to perform a conversion to Index<String> (in reality, there should have been h.GetIndex() instead...).

Because I have spent some bad amount of time trying to figure out what is happening, I have decided to disallow this conversion path by making Index constructor from Vector explicit. Now this will probably break some code (but not much of it), e.g. in theide, following line is now invalid:

Index<String> x = Split("hello;world", ';');

and has to be rewritten as

Index<String> x(Split("hello;world", ';'));

but I think it is still better to make this issue safer...

Mirek

Report message to a moderator

[Message index]

		Index constructor from Vector now explicit By: mirek on Tue, 26 February 2013 20:02
		Re: Index constructor from Vector now explicit By: koldo on Tue, 26 February 2013 23:49
		Re: Index constructor from Vector now explicit By: mirek on Wed, 27 February 2013 07:59
		Re: Index constructor from Vector now explicit By: mdelfede on Thu, 28 February 2013 12:42
		Re: Index constructor from Vector now explicit By: koldo on Fri, 01 March 2013 08:12
		Re: Index constructor from Vector now explicit By: mirek on Fri, 01 March 2013 09:00

Previous Topic:	HttpRequest added remaining HTTP methods
Next Topic:	.ini file parser refactored

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sat Aug 01 04:59:55 GMT+2 2026

Total time taken to generate the page: 0.00900 seconds