Bug #1745
Close right tabs can close all tabs
| Status: | Approved | Start date: | 06/17/2017 | |
|---|---|---|---|---|
| Priority: | High | Due date: | ||
| Assignee: | Zbigniew Rebacz | % Done: | 0% | |
| Category: | TabBar | Spent time: | - | |
| Target version: | Release 2017.2 |
Description
There is one place that allows to close all tabs using "Close right tabs" feature. All you need to do is just click on the point that is the most on the left side of control. Make sure the first tab does not highlight close button.
This could happens on the around 3-5px area - but it can depends on the UI scaling factor.
Screenshot_20170617_190742.png (68 KB)
TabBar.cpp.patch 
(1.33 KB)
History
#1 Updated by Zbigniew Rebacz almost 7 years ago
- Description updated (diff)
#2 Updated by Abdelghani Omari almost 7 years ago
- File TabBar.cpp.patch added
- Status changed from New to Patch ready
- Assignee changed from Abdelghani Omari to Zbigniew Rebacz
The bug touches the menu "Close" too,
Clicking the "Close" menu in this area causes the app to crash.
the cause is that highlight is equal to -1
patch in attachment.
#3 Updated by Zbigniew Rebacz almost 7 years ago
- Assignee changed from Zbigniew Rebacz to Miroslav Fidler
I do not have rights to commit and accept patches for TabBar - this is what Mirek should do.
#4 Updated by Zbigniew Rebacz almost 7 years ago
- Priority changed from Normal to High
Yes it is segmentation fault with TabBar. Just click close in the same place - priority should be definitely higher.
#5 Updated by Miroslav Fidler almost 7 years ago
- Status changed from Patch ready to Ready for QA
- Assignee changed from Miroslav Fidler to Abdelghani Omari
#6 Updated by Zbigniew Rebacz almost 7 years ago
- Status changed from Ready for QA to Approved
- Assignee changed from Abdelghani Omari to Zbigniew Rebacz
Thanks - works fine.