Bug #468

missing virtual function in umk

Added by Jan DolinĂ¡r over 1 year ago. Updated over 1 year ago.

Status:Approved Start:05/12/2013
Priority:Urgent Due date:
Assigned to:Miroslav Fidler % Done:

0%

Category:IDE Spent time: -
Target version:-

Description

Umk fails to build:

/home/h/upp-production/uppsrc/umk/umake.cpp: In function 'void ConsoleMainFn_()':
/home/h/upp-production/uppsrc/umk/umake.cpp:52:6: error: cannot declare variable 'ide' to be of abstract type 'Ide'
  Ide ide;
      ^
In file included from /home/h/upp-production/uppsrc/umk/umake.cpp:1:0:
/home/h/upp-production/uppsrc/umk/umake.h:80:8: note:   because the following virtual functions are pure within 'Ide':
 struct Ide : public IdeContext, public MakeBuild {
        ^
In file included from /home/h/upp-production/uppsrc/ide/Builders/Builders.h:4:0,
                 from /home/h/upp-production/uppsrc/umk/umake.h:4,
                 from /home/h/upp-production/uppsrc/umk/umake.cpp:1:
/home/h/upp-production/uppsrc/ide/Core/Core.h:85:20: note:  virtual bool IdeContext::IsPersistentFindReplace()
  virtual bool      IsPersistentFindReplace() = 0;
                    ^

Quick patch:

Index: /home/h/upp-production/uppsrc/umk/umake.h
===================================================================
--- /home/h/upp-production/uppsrc/umk/umake.h   (revision 6034)
+++ /home/h/upp-production/uppsrc/umk/umake.h   (working copy)
@@ -127,6 +127,8 @@
        virtual String    IdeGetFileName();
        virtual String    IdeGetNestFolder();

+       virtual bool IsPersistentFindReplace() { return false; }
+
        virtual void           ConsoleShow();
        virtual void           ConsoleSync();
        virtual void           ConsoleClear();

History

Updated by Miroslav Fidler over 1 year ago

  • Status changed from Patch ready to Approved

Thanks!

Also available in: Atom PDF