Home » U++ TheIDE » U++ TheIDE: CodeEditor, Assist++, Topic++ » Please bring back drag'n'drop copy
| Please bring back drag'n'drop copy [message #21095] |
Sun, 03 May 2009 19:45  |
Mindtraveller
Messages: 917
Registered: August 2007
Location: Russia, Moscow rgn.
|
Experienced Contributor |
|
|
TheIDE has nice behaviour to copy text: select text, pressing Ctrl, drag'n'drop text to destination, and it is copied.
But since one of the latest builds this feature is broken: text is no more moved (to be copied) while pressing Ctrl first. To copy, one should select text, then start dragging, then press Ctrl, then drop text,- a proccess is much less intuitive. Please bring default copying behaviour back.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Re: Please bring back drag'n'drop copy [message #21144 is a reply to message #21118] |
Tue, 05 May 2009 09:35  |
Mindtraveller
Messages: 917
Registered: August 2007
Location: Russia, Moscow rgn.
|
Experienced Contributor |
|
|
| luzr wrote on Mon, 04 May 2009 12:05 |
Well, "902r186" is no longer relevant - we are not updating "version.h" in svn at the moment (but it is something to consider).
If you are building from svn, please use svn revision number as reference.
|
Then it would be good to write SVN version number in About dialog (instead of deprecated ***r***) to avoid any confusion in future.
[Updated on: Tue, 05 May 2009 09:36] Report message to a moderator |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Re: Please bring back drag'n'drop copy [message #21235 is a reply to message #21232] |
Sun, 10 May 2009 14:04 |
Mindtraveller
Messages: 917
Registered: August 2007
Location: Russia, Moscow rgn.
|
Experienced Contributor |
|
|
Thank you for rereading initial post. I`ll detail what I mean.
Simple "moving" text works fine in any test case. The problem is specifically with cloning text. How do I used to clone text, by steps:
1. Select text
2. Hold Ctrl
3. Drag selected text (click + move)
4. Release Ctrl
5. Release left mouse button
The problem appeared in step (3), where in previous versions it was semi-transparent text with "+" sign at mouse cursor. Recently, at this step neither transparent text nor "+" is displayed. But the mouse cursor itself is changed as if I was dragging text (it is almost the same, but U++ DnD cursor has slightly more opaque shadow than native Windows` one).
Talking about the latest SVN version, after careful tests, I found following:
a) Cloning words/phrases became OK in all situations. The problem is with cloning with all the line selected (or a number of lines selected).
b) When I clone the line (after triple click or Shift+Down or mouse select - no difference), sometimes now it is cloned OK (previous version didn`t clone all the time). But sometimes (with about 50% probability) it fails to work the way I described above. And now failure is accompanied by interesting effect: at stage (4), when I release Ctrl, semitransparent text and "+" sign is appeared but disappeared after small period or after I move mouse button.
So, your tests:
1. OK
2. OK (!)
3. "sometimes fails" which is described above.
4. OK
I`ve uploaded video with DnD problem. Please notice rwo things in video:
1) each time I drag text, I press Ctrl first
2) Correct DnD mouse cursor is displayed highly minimized (a capture program bug).
http://www.youtube.com/watch?v=8wE27NHHa30
|
|
|
|
| Re: Please bring back drag'n'drop copy [message #21236 is a reply to message #21235] |
Sun, 10 May 2009 17:41 |
 |
mirek
Messages: 14290
Registered: November 2005
|
Ultimate Member |
|
|
| Mindtraveller wrote on Sun, 10 May 2009 08:04 |
Thank you for rereading initial post. I`ll detail what I mean.
Simple "moving" text works fine in any test case. The problem is specifically with cloning text. How do I used to clone text, by steps:
1. Select text
2. Hold Ctrl
3. Drag selected text (click + move)
4. Release Ctrl
5. Release left mouse button
|
Well, if you do this in this sequence, releasing Ctrl before left mouse button, it would not (and should not) work in any "conforming" Win32 app: operation is finished by releasing mouse button and actual Ctrl status at this point is what is relevant.
| Quote: |
The problem appeared in step (3), where in previous versions it was semi-transparent text with "+" sign at mouse cursor. Recently, at this step neither transparent text nor "+" is displayed. But the mouse cursor itself is changed as if I was dragging text (it is almost the same, but U++ DnD cursor has slightly more opaque shadow than native Windows` one).
|
Is in it possible that something has changed in your Win32 setup?
This almost sounds like visual glitch, like that mouse cursor is not correctly defined or composed or something...
| Quote: |
Talking about the latest SVN version, after careful tests, I found following:
a) Cloning words/phrases became OK in all situations. The problem is with cloning with all the line selected (or a number of lines selected).
b) When I clone the line (after triple click or Shift+Down or mouse select - no difference), sometimes now it is cloned OK (previous version didn`t clone all the time). But sometimes (with about 50% probability) it fails to work the way I described above. And now failure is accompanied by interesting effect: at stage (4), when I release Ctrl, semitransparent text and "+" sign is appeared but disappeared after small period or after I move mouse button.
|
Correctly as with correct mouse shape?
| Quote: |
1) each time I drag text, I press Ctrl first
|
Well, as I explained above, [+] there is only visual quide. It should change on pressing/releasing Ctrl. Operation is defined n mouse release.
Mirek
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Re: Please bring back drag'n'drop copy [message #21265 is a reply to message #21257] |
Mon, 11 May 2009 11:59 |
|
mirek
Messages: 14290
Registered: November 2005
|
Ultimate Member |
|
|
I am sorry, I have to ask again:)
Without Ctrl, result is 100% predictable and it is move.
With Ctrl, result is random.
(I just cannot believe that... 
Anyway, some DUMPs:
void UDropTarget::DnD(POINTL pl, bool drop, DWORD *effect, DWORD keys)
{
dword e = *effect;
LOG("DnD " << e == DROPEFFECT_COPY);
*effect = DROPEFFECT_NONE;
if(!ctrl)
return;
PasteClip d;
d.dt = this;
d.paste = drop;
d.accepted = false;
d.allowed = 0;
d.action = 0;
if(e & DROPEFFECT_COPY) {
d.allowed = DND_COPY;
d.action = DND_COPY;
}
if(e & DROPEFFECT_MOVE) {
d.allowed |= DND_MOVE;
if(Ctrl::GetDragAndDropSource())
d.action = DND_MOVE;
}
if((keys & MK_CONTROL) && (d.allowed & DND_COPY))
d.action = DND_COPY;
if((keys & (MK_ALT|MK_SHIFT)) && (d.allowed & DND_MOVE))
d.action = DND_MOVE;
ctrl->DnD(Point(pl.x, pl.y), d);
DDUMP(d.action);
if(d.IsAccepted()) {
if(d.action == DND_MOVE)
*effect = DROPEFFECT_MOVE;
if(d.action == DND_COPY)
*effect = DROPEFFECT_COPY;
}
}
STDMETHODIMP UDropSource::GiveFeedback(DWORD dwEffect)
{
LOG("GiveFeedback " << (dwEffect & DROPEFFECT_COPY) == DROPEFFECT_COPY);
Image m = IsNull(move) ? copy : move;
if((dwEffect & DROPEFFECT_COPY) == DROPEFFECT_COPY) {
if(!IsNull(copy)) m = copy;
}
else
if((dwEffect & DROPEFFECT_MOVE) == DROPEFFECT_MOVE) {
if(!IsNull(move)) m = move;
}
else
m = no;
Ctrl::OverrideCursor(m);
Ctrl::SetMouseCursor(m);
return S_OK;
}
Try with Ctrl pushed....
Mirek
|
|
|
|
|
|
| Re: Please bring back drag'n'drop copy [message #21268 is a reply to message #21266] |
Mon, 11 May 2009 12:57 |
|
mirek
Messages: 14290
Registered: November 2005
|
Ultimate Member |
|
|
| Mindtraveller wrote on Mon, 11 May 2009 06:41 |
And again 
> Without Ctrl, result is 100% predictable and it is move
YES!
>With Ctrl, result is random
Ctrl->drag = YES! (You`ve seen that on video, what a shame it doesn`t indicate pressed keys)
drag->Ctrl = WORKS 100%
So the problem is with initial period when Ctrl is ALREADY pressed before dragging start.
Your patch doesn`t compile (I patched Win32DnD.cpp):
> LOG("DnD " << e == DROPEFFECT_COPY);
error C2678: binary '==' : no operator found which takes a left-hand operand of type 'Upp::Stream' (or there is
no acceptable conversion)
> STDMETHODIMP UDropSource::GiveFeedback(DWORD dwEffect)
error C2027: use of undefined type 'Upp::UDropSource'
> LOG("GiveFeedback " << (dwEffect & DROPEFFECT_COPY) == DROPEFFECT_COPY);
error C2678: binary '==' : no operator found which takes a left-hand operand of type 'Upp::Stream' (or there is
no acceptable conversion)
... (about 5 more errors, please try to compile it)
|
Ah, sorry, put parenthesis around == operators please...
void UDropTarget::DnD(POINTL pl, bool drop, DWORD *effect, DWORD keys)
{
dword e = *effect;
LOG("DnD " << (e == DROPEFFECT_COPY));
*effect = DROPEFFECT_NONE;
if(!ctrl)
return;
PasteClip d;
d.dt = this;
d.paste = drop;
d.accepted = false;
d.allowed = 0;
d.action = 0;
if(e & DROPEFFECT_COPY) {
d.allowed = DND_COPY;
d.action = DND_COPY;
}
if(e & DROPEFFECT_MOVE) {
d.allowed |= DND_MOVE;
if(Ctrl::GetDragAndDropSource())
d.action = DND_MOVE;
}
DDUMP(keys & MK_CONTROL);
if((keys & MK_CONTROL) && (d.allowed & DND_COPY))
d.action = DND_COPY;
if((keys & (MK_ALT|MK_SHIFT)) && (d.allowed & DND_MOVE))
d.action = DND_MOVE;
ctrl->DnD(Point(pl.x, pl.y), d);
DDUMP(d.action);
if(d.IsAccepted()) {
if(d.action == DND_MOVE)
*effect = DROPEFFECT_MOVE;
if(d.action == DND_COPY)
*effect = DROPEFFECT_COPY;
}
}
STDMETHODIMP UDropSource::GiveFeedback(DWORD dwEffect)
{
LOG("GiveFeedback " << ((dwEffect & DROPEFFECT_COPY) == DROPEFFECT_COPY));
Image m = IsNull(move) ? copy : move;
if((dwEffect & DROPEFFECT_COPY) == DROPEFFECT_COPY) {
if(!IsNull(copy)) m = copy;
}
else
if((dwEffect & DROPEFFECT_MOVE) == DROPEFFECT_MOVE) {
if(!IsNull(move)) m = move;
}
else
m = no;
Ctrl::OverrideCursor(m);
Ctrl::SetMouseCursor(m);
return S_OK;
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Goto Forum:
Current Time: Sat Apr 25 14:33:14 GMT+2 2026
Total time taken to generate the page: 0.01001 seconds
|
U++ framework
Search
Help
Members
Register
Login
Home
