U++ framework: U++ Library : Other (not classified elsewhere) » Util.cpp static sIniFile BUG FIX

Home » U++ Library support » U++ Library : Other (not classified elsewhere) » Util.cpp static sIniFile BUG FIX

Show: Today's Messages :: Polls :: Message Navigator
E-mail to friend

Util.cpp static sIniFile BUG FIX [message #23856]

Fri, 27 November 2009 09:52

kohait00
Messages: 939
Registered: July 2009
Location: Germany

Experienced Contributor

hi there

in Core/Util.cpp:390
String GetIniKey(const char *id, const String& def)

..
key = LoadIniFile(sIniFile ? sIniFile : ~ConfigFile("q.ini"));
..

should be changed to something like

...
key = LoadIniFile(!(String() = sIniFile).IsEmpty() ? sIniFile : ~ConfigFile("q.ini"));
...

since the sIniFile is a
static char sIniFile[256];

and the compare yields always true, where the logic should be "if sIniFile has conent, use sIniFile", right?

Report message to a moderator

Re: Util.cpp static sIniFile BUG FIX [message #23866 is a reply to message #23856]

Fri, 27 November 2009 23:00

mirek
Messages: 14290
Registered: November 2005

Ultimate Member

kohait00 wrote on Fri, 27 November 2009 03:52

hi there

in Core/Util.cpp:390
String GetIniKey(const char *id, const String& def)

..
key = LoadIniFile(sIniFile ? sIniFile : ~ConfigFile("q.ini"));
..

should be changed to something like

...
key = LoadIniFile(!(String() = sIniFile).IsEmpty() ? sIniFile : ~ConfigFile("q.ini"));
...

since the sIniFile is a
static char sIniFile[256];

and the compare yields always true, where the logic should be "if sIniFile has conent, use sIniFile", right?

Thanks, accidentally, I have already fixed this bug while finding it hard way - my major project updating got broken... Smile

Smile

Mirek

Report message to a moderator

Previous Topic:	Painter DrawLine proposal
Next Topic:	Painter DrawLineStroke proposal

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

PDF

]

Current Time: Fri May 01 21:55:15 GMT+2 2026

Total time taken to generate the page: 0.00461 seconds