U++ framework: ArrayCtrl, HeaderCtrl & GridCtrl

Home » U++ Library support » ArrayCtrl, HeaderCtrl & GridCtrl » Problem with IsRowEditable

Show: Today's Messages :: Polls :: Message Navigator
E-mail to friend

Problem with IsRowEditable [message #36181]

Wed, 09 May 2012 12:18

koldo
Messages: 3460
Registered: August 2008

Senior Veteran

Hello Daniel

Actual implementation is:

bool GridCtrl::IsRowEditable(int r)
{
	if(r < 0)
		r = curpos.y;
	else
		r += fixed_rows;
	
	return vitems[r].editable && hitems[curpos.x].editable;
}

I have found possible to call IsRowEditable() with r = -1 and curpos.y = -1, so an exception is thrown because of vitems[-1].

May you check this case in the function?

Best regards
Iñaki

Report message to a moderator

Re: Problem with IsRowEditable [message #36183 is a reply to message #36181]

Wed, 09 May 2012 12:37

unodgs
Messages: 1367
Registered: November 2005
Location: Poland

Ultimate Contributor

koldo wrote on Wed, 09 May 2012 06:18

Hello Daniel
I have found possible to call IsRowEditable() with r = -1 and curpos.y = -1, so an exception is thrown because of vitems[-1].

Please describe step by step how to achieve such a grid state, only then I will be able to fix it.

Report message to a moderator

Re: Problem with IsRowEditable [message #36187 is a reply to message #36183]

Wed, 09 May 2012 15:34

koldo
Messages: 3460
Registered: August 2008

Senior Veteran

unodgs wrote on Wed, 09 May 2012 12:37

koldo wrote on Wed, 09 May 2012 06:18

Hello Daniel
I have found possible to call IsRowEditable() with r = -1 and curpos.y = -1, so an exception is thrown because of vitems[-1].

Please describe step by step how to achieve such a grid state, only then I will be able to fix it.

Hello Daniel

That is going to be very difficult as it happened when moving a row. Anyway I will try to get that again.

Best regards
Iñaki

Report message to a moderator

Re: Problem with IsRowEditable [message #36337 is a reply to message #36187]

Mon, 21 May 2012 09:58

koldo
Messages: 3460
Registered: August 2008

Senior Veteran

Hello Daniel

Problem found (not the solution Smile

). I enclose you a super simple test case.

GridCtrlDragtest::GridCtrlDragtest()
{
	CtrlLayout(*this, "Window title");
	
	grid.ResizeColMode(0);
	grid.Inserting().Appending().Removing().Editing().Duplicating().Clipboard().SetToolBar()
					.EvenColor().MovingRows(1).Dragging().DrawFocus().ColoringMode(2)
					.SetCursor(0);
	
	grid.AddColumn("First");
	grid.AddColumn("Second");
	
	grid.Clear();		// Problem appears if this line is set
	grid.Add("Hello", "World");
	grid.Add("Hello2", "World2");
}

GUI_APP_MAIN
{
	GridCtrlDragtest().Run();
}

When dragging second line before first line it says "Moving row 2 before row 0". It should have to say "row 1". After that the exception appears. If I remove the Clear(), everything works perfect.

index.php?t=getfile&id=3752&private=0