U++ forum: Welcome to the forum

Search on this site

Search in forums

Home » U++ Library support » Menus&Toolbars » [Minor fix - Linux] Insufficient value for the variable leftgap in MenuBar CH_STYLE.

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

[Minor fix - Linux] Insufficient value for the variable leftgap in MenuBar CH_STYLE. [message #38940]

Mon, 28 January 2013 16:44

Klugier
Messages: 1099
Registered: September 2012
Location: Poland, Kraków

Senior Contributor

Hello

In my opinion default MenuBar value of leftgap is too low. It should be around 24 not 16 pixeles as it is now. Where you can find this initialization? Go to CtrlLib, next MenuBar.cpp, at the end find the line number 46.

I have attached demonstration screenshots with leftgap value on level 16 and 24 pixels. (.zip file - 3 screenshots). Note the adhesion of white outline image when the one of menu bar possition is active.

P.S.
I have noticed the same problem on Windows XP.

Sincerely,
Klugier

Attachment: BarImages.rar
(Size: 25.04KB, Downloaded 355 times)

U++ - one framework to rule them all.

Report message to a moderator

Re: [Minor fix - Linux] Insufficient value for the variable leftgap in MenuBar CH_STYLE. [message #39214 is a reply to message #38940]

Thu, 28 February 2013 17:29

mirek
Messages: 14258
Registered: November 2005

Ultimate Member

I was looking OK in my current Mint skin, but I have increased the value to 20 (afraid that more might make it look bad in some themes).

Mirek

Report message to a moderator

Re: [Minor fix - Linux] Insufficient value for the variable leftgap in MenuBar CH_STYLE. [message #39257 is a reply to message #39214]

Wed, 06 March 2013 15:12

Klugier
Messages: 1099
Registered: September 2012
Location: Poland, Kraków

Senior Contributor

Hello Mirek,

It was looking good on yours Mint skin, because it used gtk-backend (Even if we set leftgap to 100, we will not see difference on gtk-backend). This value only determinates X11-backend gap (I have made several tests).

Personally, I think that 26 is optimal value for X11 backend, but 20 is definitely too low. If you have time You can make test without and with gtk-backend.

Sincerely,
Klugier

U++ - one framework to rule them all.

Report message to a moderator

Re: [Minor fix - Linux] Insufficient value for the variable leftgap in MenuBar CH_STYLE. [message #39259 is a reply to message #39257]

Wed, 06 March 2013 18:49

mirek
Messages: 14258
Registered: November 2005

Ultimate Member

Ah, now I can see what you have in mind: NOGTK mode.

OK, fixed (it is now 24).

Report message to a moderator

Re: [Minor fix - Linux] Insufficient value for the variable leftgap in MenuBar CH_STYLE. [message #40179 is a reply to message #39259]

Fri, 28 June 2013 21:52

Klugier
Messages: 1099
Registered: September 2012
Location: Poland, Kraków

Senior Contributor

Hello Mirek,

I think we should extend this value to 26. It is the default constant for gtk backend and it should totally eliminated menu bar images artifacts on pure X11, Wine and old Windows such as XP.

[CtrlLib > MenuBar.cpp > Line 46]