Hello Mirek,


I've succesfully compiled the branch on Linux, however, it doesn't seem to work at all. (No assist/code completion, etc...)

(Linux 5.18, GNOME 42.1 (Wayland), LLVM/CLANG 13.0.1 (x64))

Keep in mind that this was just a quick test, Later I'll do some more...


Best regards,
Oblivion

Hi,

I must be missing something here... Compilation fails with:

C:\upp-git\upp.src\uppsrc\ide/clang/clang.h (5): fatal error C1083: Cannot open include file: 'clang-c/Index.h': No such file or directory

Best regards,

Tom

EDIT: This is on Windows using MSBT22x64 and the same happens with CLANGx64.

OK, I see. Maybe I'll wait a while, until it becomes part of nightly with those dependencies and settings included...

Thanks and best regards,

Tom

I checked a clang-enabled version of TheIDE in Linux (debug version).
It is using 100% of CPU all the time. Initially, I thought that this is Clang indexing UPP files, but after waiting for 50 minutes I figured out that this must be a bug with TheIDE.

Can please somebody retest in Linux? I believe autocomplete works now great (I mean, fast enough).

WStringBuffer txt;
txt.

mirek wrote on Thu, 07 July 2022 07:23

Can please somebody retest in Linux? I believe autocomplete works now great (I mean, fast enough).

"make -f umkMakefile" - works.
Regular "make" (build TheIDE) didn't work (problem with linking).

Problem with CPU is fixed.
Autocomplete doesn't work for me. For example:

WStringBuffer txt;
txt.

Dot won't be autocompled. Ctrl+Space doesn't help either. I also tried autocomplete with TAB.
To be fair, I never used autocomplete with TheIDE before, but I use it with VIM all the time.

Are you testing latest llbm_ide branch, right? (make reference is confusing me a bit)

Can you test removing "CXTranslationUnit_PrecompiledPreamble" from sources (you will easily find where)?

So Ctrl+Space does show something?

You can also try something selfcontained (no headers) like

struct Foo { int x; };

void foo() { Foo(). };

Mirek

Interestingly, umk doesn't check dependencies anymore. I need to "rebuild all" each time.

So Ctrl+Space does show something?

You can also try something selfcontained (no headers) like

struct Foo { int x; };

void foo() { Foo(). };

Mirek

mirek wrote on Thu, 07 July 2022 12:49

So Ctrl+Space does show something?

You can also try something selfcontained (no headers) like

struct Foo { int x; };

void foo() { Foo(). };

Mirek

In this case it works (with CXTranslationUnit_PrecompiledPreamble and no headers at all).

Now probably stupid question, I am just asking because I was there before: Are you sure your test code is syntactically correct? Does it compile? Is not it e.g. in #if 0 block?

Also: What happens if you actually add some header? Does it break?

I'm testing TheIDE on Void Linux (rolling distro), which is using clang version 12.0.1 at this time.

That said, you still have not told me what Ctrl+Space does. Obviously it shows something based on your posts.

Does it show U++ functions e.g.?

bool amap::AnalyzeMap(String fn) {
	String map = LoadFile(fn);
	char nm[1024];
	if (IsNull(map))
		return false;

	MapFileParser::MSVC MSVC(map);
	MapFileParser::CodeWarriorW CWW(map);
	MapFileParser::CodeWarrior CW(map);
	MapFileParser::PS3 PS3(map);
	MapFileParser::GCC3 GCC3(map, mcr);

	int addr;
	int sect_len;
	int prev_size = 0;
	uint64 pref_addr;
	int size;
	int modulen;
	int filen;
	String sect_name;
	String sect_class;
	String funct_name;
	String module_name;
	String file_name;
	String app_name;
	String time_stamp;
	One<MFile> cur_mfile(new MFile);

	if (map.StartsWith(elf::ElfMagic, 4)) {
		// Elf file.
		is32bit = map[4] == elf::ELFCLASS32;
		isLittleEndian = map[5] == elf::ELFDATA2LSB;
		const uint8 osABI = map[6];
		const uint8 abiVersion = map[7];
		const elf::Elf32_Ehdr* hdr = reinterpret_cast<const elf::Elf32_Ehdr*>(map.Begin());

Or, opposite, does autocomplete work with std::string? (with proper includes, of course) (in that case there would be a problem with include paths)

#include <string>

struct Foo { int x; };

void foo() { Foo(); };

int main(int argc, const char *argv[])
{
	std::string str;
	str.
	return 0;
}

That said, you still have not told me what Ctrl+Space does. Obviously it shows something based on your posts.

Does it show U++ functions e.g.?

I tested with this app.
It is a real app. And autocompletion doesn't work at any place.

Novo wrote on Thu, 07 July 2022 13:39

I tested with this app.
It is a real app. And autocompletion doesn't work at any place.

Actually, it works for locally defined symbols.
TheIDE is unable to resolve and autocomplete members of a class.
The app is just one cpp file less that 2K lines of code.

I believe this is a problem with libclang because I'm getting the same behavior with VIM and ccls Language Server.

I believe you need to use LibTooling instead of LibClang with TheIDE.

Now it is definitely a temporary solution as it is quite slow that way, hopefully we will find a fix soon.

bool App::Parse(const String& file_name) {
	using namespace conllu;

	FileMapping s;
	if (!s.Open(file_name))
		return false;
	if (!s.Map(0, static_cast<dword>(s.GetFileSize())))
		return false;

	arr.Clear();
	sent.Clear();
	conlluTree.Clear();

	sentv.Clear();
	Parser p(reinterpret_cast<const char*>(s.Begin()), reinterpret_cast<const char*>(s.End()), sentv);

	while (p.Sentence()) ;

	for (const drtree::Sentence& v: sentv)
		sent.Add(AsString(v.GetWordV().GetCount()), v.GetText());

	return true;
}

mirek wrote on Sat, 09 July 2022 07:11

Now it is definitely a temporary solution as it is quite slow that way, hopefully we will find a fix soon.

I tested latest source code.
I do not see any changes.
Basically, source code where autocompletion doesn't work:

bool App::Parse(const String& file_name) {
	using namespace conllu;

	FileMapping s;
	if (!s.Open(file_name))
		return false;
	if (!s.Map(0, static_cast<dword>(s.GetFileSize())))
		return false;

	arr.Clear();
	sent.Clear();
	conlluTree.Clear();

	sentv.Clear();
	Parser p(reinterpret_cast<const char*>(s.Begin()), reinterpret_cast<const char*>(s.End()), sentv);

	while (p.Sentence()) ;

	for (const drtree::Sentence& v: sentv)
		sent.Add(AsString(v.GetWordV().GetCount()), v.GetText());

	return true;
}

In case of "arr.", "sent.", "conlluTree.", e.t.c. autocompletion doesn't work.
In case of "s." and "p." it does.

The only reason LibClang is needed is "name resolution". It is much harder to develop a name resolution algorithm than to make a C++ parser itself. If name resolution doesn't work for some reason, then there is no reason to use LibClang.

There are better solutions for parsing.

And these are?

It works 100% with clang 14 in Windows, hence I think the problem is somewhere else than in clang. It works without preamble in clang 10 for me too. Too soon to try something else at this point.

Now this is one of troubles I expected before going clang - we are now victim of external incompatibilities. But what is done is done.

mirek wrote on Sat, 09 July 2022 18:49

It works 100% with clang 14 in Windows, hence I think the problem is somewhere else than in clang. It works without preamble in clang 10 for me too. Too soon to try something else at this point.

IMHO, you just haven't tested it very well yet. I was just "lucky" to hit a bug with my first test. My code is not that complicated. It is mostly C++98, but I use a lot of simple templates, but nothing fancy like SFINAE.