U++ framework
Do not panic. Ask here before giving up.

Home » Community » U++ community news and announcements » get_i
Re: get_i [message #54274 is a reply to message #54273] Wed, 17 June 2020 23:21 Go to previous messageGo to previous message
Novo is currently offline  Novo
Messages: 1431
Registered: December 2006
Ultimate Contributor
mirek wrote on Wed, 17 June 2020 15:03

Thanks. Trunk version are a bit different now, can you review?

In your last commit you've added std::forward not to all places.
I've attached my version.
I also changed a functor signature in "void iter_get(I s, Args& ...args)".
Just a reference is fine there ...
IMHO, functors and iterators should be passed by reference to avoid extra-copying ...
  • Attachment: Fn.h
    (Size: 3.28KB, Downloaded 295 times)


Regards,
Novo
 
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: ide: Assist parsing now parallel and some of it background
Next Topic: 2020.1 officially released
Goto Forum:
  


Current Time: Sat Apr 25 23:50:03 GMT+2 2026

Total time taken to generate the page: 0.00805 seconds