U++ forum: Welcome to the forum

Search on this site

Search in forums

Home » U++ Library support » U++ Library : Other (not classified elsewhere) » Add and AddPick should return reference to added element

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Add and AddPick should return reference to added element [message #1674]

Mon, 13 March 2006 15:54

hojtsy
Messages: 241
Registered: January 2006
Location: Budapest, Hungary

Experienced Member

Vector & Array has these methods:

T&   Add()
void Add(const T& x)
void AddPick(pick_ T& x)

I would like all of these to return reference to added element as in:

T& Add()                 
T& Add(const T& x)
T& AddPick(pick_ T& x)

So that I can write code like array.Add(someThing).ProcessSomething(r);

Report message to a moderator

Re: Add and AddPick should return reference to added element [message #1681 is a reply to message #1674]

Mon, 13 March 2006 20:24

aroman
Messages: 18
Registered: November 2005

Promising Member

Quote:

array.Add(someThing).ProcessSomething(r);

I'm not sure this is a good idea. It gives the impression that ProcessSomething is operating on array rather than someThing.

- Augusto

Report message to a moderator

Re: Add and AddPick should return reference to added element [message #1682 is a reply to message #1681]

Mon, 13 March 2006 20:29

hojtsy
Messages: 241
Registered: January 2006
Location: Budapest, Hungary

Experienced Member

You can anyway do array.Add().ProcessSomething(s), so this would just be a harmonization

Report message to a moderator

Re: Add and AddPick should return reference to added element [message #1689 is a reply to message #1681]

Mon, 13 March 2006 21:27

mirek
Messages: 13975
Registered: November 2005

Ultimate Member

aroman wrote on Mon, 13 March 2006 14:24

Quote:

array.Add(someThing).ProcessSomething(r);

I'm not sure this is a good idea. It gives the impression that ProcessSomething is operating on array rather than someThing.

- Augusto

Actually, I thought that it is not a good idea for exactly the opposite reason - because it operates on the Array, not someThing.

In any case, this different interpretations indicate ambiguous interface.

Mirek

Report message to a moderator

Re: Add and AddPick should return reference to added element [message #1690 is a reply to message #1689]

Mon, 13 March 2006 21:47

hojtsy
Messages: 241
Registered: January 2006
Location: Budapest, Hungary

Experienced Member

So what about array.Add().ProcessSomething(s) ? Is that trivial for everyone? The reference is returned for convenience so that client code could operate on the newly inserted element. The same would be needed for the other Add methods.

Report message to a moderator

Re: Add and AddPick should return reference to added element [message #1691 is a reply to message #1690]

Mon, 13 March 2006 21:59

mirek
Messages: 13975
Registered: November 2005

Ultimate Member

hojtsy wrote on Mon, 13 March 2006 15:47

I think there is no ambiguity....

Well, I am not saying that what you propose is a bad idea.... Just during 6 years of current interface I never really felt that this would help.

Maybe it is just that U++ way of coding does not lead to situations where this has any benefit.

Think: you are using Add with parameter variant just for value elements - and you are seldom calling methods for values, much less mutating methods. That is also the source of ambiguity.

Mirek

Report message to a moderator

Previous Topic:	Linux SDL [BUG?][WORKAROUND]
Next Topic:	subclassing LineEdit is ugly

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Fri Apr 19 04:20:39 CEST 2024

Total time taken to generate the page: 0.02634 seconds