Overview
Examples
Screenshots
Comparisons
Applications
Download
Documentation
Tutorials
Bazaar
Status & Roadmap
FAQ
Authors & License
Forums
Funding Ultimate++
Search on this site
Search in forums












SourceForge.net Logo
Home » U++ TheIDE » U++ TheIDE: Compiling, Linking, Debugging of your packages » I keep getting the same "cannot open exe for writing" error...
Re: I keep getting the same "cannot open exe for writing" error... [message #50652 is a reply to message #50651] Thu, 29 November 2018 12:23 Go to previous messageGo to next message
mirek is currently offline  mirek
Messages: 11963
Registered: November 2005
Ultimate Member
cbpporter wrote on Thu, 29 November 2018 12:21
I tested with 12587.

The issue is not fixed.

In the past I would get a hang up when the process locked and I had to quit TheIDE.

Now, I get a message telling me that the binary can't be opened for writing. So I guess it is an improvement. The process can't be killed by windows manager and I need to shut down TheIDE.

A few months ago I tried everything to fix this but gave up. I was using WinAPI (WaitForSingleObject if I remember correctly) to wait for the process. Yet the process would not finish and TheIDE would hang forever.

			dword exitcode;
			int start = msecs();
			while(GetExitCodeProcess(hProcess, &exitcode) && exitcode == STILL_ACTIVE && msecs(start) < 3000)
				Sleep(1);


This behaves better than WaitForSingleObject since it won't lock forever, but I suppose testing GetExitCodeProcess after 3 seconds will still give an active result in the case where the exe can't be written too. Maybe that should be logged somewhere and shown in TheIDE?

There must be a more aggressive way o killing a process as a fail safe?




Perhaps we could try to add Exclamation after that if process is still active - at least that would show us that this is the problem.
Re: I keep getting the same "cannot open exe for writing" error... [message #50653 is a reply to message #50652] Thu, 29 November 2018 12:27 Go to previous messageGo to next message
cbpporter is currently offline  cbpporter
Messages: 1391
Registered: September 2007
Senior Contributor
mirek wrote on Thu, 29 November 2018 13:23

Perhaps we could try to add Exclamation after that if process is still active - at least that would show us that this is the problem.


Yes please!

Also, since I updated, when running command line programs with Ctrl-F5, I get this lovely output message:
Quote:
<--- Finished in (-5371:-45.-1), exitcode: 0 --->

Re: I keep getting the same "cannot open exe for writing" error... [message #50655 is a reply to message #50651] Thu, 29 November 2018 13:41 Go to previous messageGo to next message
peterh is currently offline  peterh
Messages: 46
Registered: November 2018
Location: Germany
Member
The question is, if your process needs more time than 3 seconds to terminate.
The other question is can it been terminated with this method at all?
If it hangs in blocking IO in kernel mode, possibly it cannot be terminated.
I do regulary see applications that do serial IO via the .NET and if these crash, then
Windows does not shut down because it waits for the process forever.

This is why I proposed tho give report to the user.

There could be a message box:

"Process termination timeout"
"Wait and retry?" "Ignore and try to Close anyway"

WaitForSingleObject should return these Values:

WAIT_OBJECT_0 means the thread has stopped.
WAIT_TIMEOUT means the thread is running.

Not that I have practical experience with this. This is what I found in MSDN.

Edit:
Just for explanation:
Even if the processhandle is closed and the process detached the file cannot been deleted or modified as long as the process is running.
This is, because windows needs the .exe file for virtual memory paging, when the process is still running.
In this case the file could be renamed and marked for deletion.

[Updated on: Thu, 29 November 2018 16:22]

Report message to a moderator

Re: I keep getting the same "cannot open exe for writing" error... [message #50656 is a reply to message #50653] Thu, 29 November 2018 14:10 Go to previous messageGo to next message
mirek is currently offline  mirek
Messages: 11963
Registered: November 2005
Ultimate Member
cbpporter wrote on Thu, 29 November 2018 12:27
mirek wrote on Thu, 29 November 2018 13:23

Perhaps we could try to add Exclamation after that if process is still active - at least that would show us that this is the problem.


Yes please!

Also, since I updated, when running command line programs with Ctrl-F5, I get this lovely output message:
Quote:
<--- Finished in (-5371:-45.-1), exitcode: 0 --->



Added & fixed...
Re: I keep getting the same "cannot open exe for writing" error... [message #50659 is a reply to message #50651] Fri, 30 November 2018 09:01 Go to previous messageGo to next message
peterh is currently offline  peterh
Messages: 46
Registered: November 2018
Location: Germany
Member
Hi,

I do not know how Windows terminates a process.
I have however done WIN32 programming years ago before, even Kernel debugging. (Debugging a kernel mode driver)
So I have ideas about it.
Windows might inject an ExitProcess call into the code of the process in order to terminate it with the least damage possible.
This would not work, if the process doesnt run (e.g. hangs in blocking IO in kernel mode).
Also this can be delayed, if heavy background activity happens, e.g. swapping and it could be necessary to swap portions of the debugged process in.
In these cases I can imagine, TerminateProcess would need time or might be impossible.

All the best,

Peter

[Updated on: Fri, 30 November 2018 09:04]

Report message to a moderator

Re: I keep getting the same "cannot open exe for writing" error... [message #50660 is a reply to message #50659] Fri, 30 November 2018 11:48 Go to previous messageGo to next message
peterh is currently offline  peterh
Messages: 46
Registered: November 2018
Location: Germany
Member
I have seen this same error with MinGW on Window7 32 Bit.

(): Linking has failed
(): C:/upp/bin/mingw64/32/bin/../lib/gcc/i686-w64-mingw32/7.1.0/ ../../../../i686-w64-mingw32/bin/ld.exe: cannot open output file C:\up
p\out\reference\MINGW.Debug.Debug_Full.Gui.Mt.Noblitz\CoWork .exe: Permission denied
(): collect2.exe: error: ld returned 1 exit status

It happens reproducibly when I start CoWork.exe in debug mode and terminate it with stop.
The process stays in memory after termination.
In this case the terminated process can be removed with the Windows Taskmanager.

Edit:
I retried this with MingW 32 and 64 on a faster Computer, running Windows 10 64 Bit.
There it doesnt happen.

[Updated on: Sat, 01 December 2018 14:13]

Report message to a moderator

Re: I keep getting the same "cannot open exe for writing" error... [message #50688 is a reply to message #50660] Wed, 05 December 2018 21:52 Go to previous messageGo to next message
peterh is currently offline  peterh
Messages: 46
Registered: November 2018
Location: Germany
Member
Hi,

I want to add this, because it might help others:

I went back to the 2018.1 stable build, because I had problems with the nightly builds.
With 2018.1 the aforementioned problem occurs frequently to me.
Then I added WaitForSingleObject(hProcess,10000) to Pdb::Stop() as aforementioned.
This did not cure the problem, but did also not cause any additional effects like delays.

Then I did see, the Ide project had the flags "GUI" and no other.
So I recompiled Theide with flags "GUI MT", because I believe, it could be multithreaded.
Apparently this cured the problem for me. It did not happen again since 2 hours now.

All the best,

Peter

[Updated on: Wed, 05 December 2018 21:57]

Report message to a moderator

Re: I keep getting the same "cannot open exe for writing" error... [message #50690 is a reply to message #50688] Wed, 05 December 2018 23:09 Go to previous messageGo to next message
mirek is currently offline  mirek
Messages: 11963
Registered: November 2005
Ultimate Member
peterh wrote on Wed, 05 December 2018 21:52

Then I did see, the Ide project had the flags "GUI" and no other.
So I recompiled Theide with flags "GUI MT", because I believe, it could be multithreaded.
Apparently this cured the problem for me. It did not happen again since 2 hours now.


No, that just shows how elusive this issue is. "MT" flag is ignored since ~2016. We are now MT always.

Mirek
Re: I keep getting the same "cannot open exe for writing" error... [message #50692 is a reply to message #50690] Wed, 05 December 2018 23:40 Go to previous messageGo to next message
peterh is currently offline  peterh
Messages: 46
Registered: November 2018
Location: Germany
Member
Could be.
Otherwise the difference was drastic.
I had written "MT" into the compiler options.
Microsoft docs for VC 2015 say /MT will define the flag _MT and this will tell the linker to link the multithreaded libraries and/or DLLs
(I use VC2017)
Is this info outdated?

[Updated on: Wed, 05 December 2018 23:45]

Report message to a moderator

Re: I keep getting the same "cannot open exe for writing" error... [message #50694 is a reply to message #50692] Thu, 06 December 2018 10:32 Go to previous messageGo to next message
mirek is currently offline  mirek
Messages: 11963
Registered: November 2005
Ultimate Member
peterh wrote on Wed, 05 December 2018 23:40
Could be.
Otherwise the difference was drastic.
I had written "MT" into the compiler options.
Microsoft docs for VC 2015 say /MT will define the flag _MT and this will tell the linker to link the multithreaded libraries and/or DLLs
(I use VC2017)
Is this info outdated?


Builders/MscBuilder.cpp 275

-MT is hardwired. It is always there...

Mirek
Re: I keep getting the same "cannot open exe for writing" error... [message #50695 is a reply to message #50694] Thu, 06 December 2018 10:35 Go to previous messageGo to next message
mirek is currently offline  mirek
Messages: 11963
Registered: November 2005
Ultimate Member
Perhaps we should now concentrate on

			while(threads.GetCount())
				RemoveThread(threads.GetKey(0)); // To CloseHandle
			UnloadModuleSymbols();
			SymCleanup(hProcess);
			CloseHandle(hProcess);


part... I guess with current patch, we can be fairly sure that process is terminated for good (otherwise it would display an Exclamation)
Re: I keep getting the same "cannot open exe for writing" error... [message #50697 is a reply to message #50695] Thu, 06 December 2018 19:23 Go to previous messageGo to next message
peterh is currently offline  peterh
Messages: 46
Registered: November 2018
Location: Germany
Member
Thank you very much.
I checked it, and it is as you said.
As this is an annoying problem for me, I think I will insert some debug messages into my own TheIde compilation and try,
if I can find something out that is helpful.

All the best,

Peter
Re: I keep getting the same "cannot open exe for writing" error... [message #50700 is a reply to message #50697] Thu, 06 December 2018 20:53 Go to previous messageGo to next message
peterh is currently offline  peterh
Messages: 46
Registered: November 2018
Location: Germany
Member
I have now changed the code in the following way:

		if(hProcess != INVALID_HANDLE_VALUE) {
			DebugActiveProcessStop(processid);
			TerminateProcess(hProcess, 0);
			DWORD retval = MsgWaitForMultipleObjects(
                                      1, 		//DWORD        nCount,
                                      &hProcess, 	//const HANDLE *pHandles,
                                      true, 		//BOOL         fWaitAll,
                                      10000, 		//DWORD        dwMilliseconds,
                                      0  		//DWORD        dwWakeMask
				      );
			if (retval == WAIT_TIMEOUT)   Exclamation("WAIT_TIMEOUT");
			if (retval == WAIT_ABANDONED) Exclamation("WAIT_ABANDONED");
		
			WaitForSingleObject(hProcess,10000);
			while(threads.GetCount())
				RemoveThread(threads.GetKey(0)); // To CloseHandle
			UnloadModuleSymbols();
			SymCleanup(hProcess);
			CloseHandle(hProcess);
		}



I did this because I have read, the WaitForSingleObject() call can return prematurely under some special circumstances.
I cannot explain it, because Microsoft cannot explain it clearly. Twisted Evil
The explanations given are misunderstandable or ambigous and there are subtile typos sometimes. And no examples Crying or Very Sad
I simply try it, if someone understands this perfectly, it will be appreciated.
After I did this, something changed: Stopping the debugee needs about 4 seconds, which is perfectly ok for me.
Edit: I added some debug code
The reason for the 4 seconds delay is not WAIT_TIMEOUT and is not WAIT_ABANDONED.
I will add some code to log the reason tomorrow. (Still I am learning Upp, needs more time than usual)
Ok, I will try this over the next few days and then report again.

So long,

Peter

[Updated on: Thu, 06 December 2018 22:40]

Report message to a moderator

Re: I keep getting the same "cannot open exe for writing" error... [message #50712 is a reply to message #50700] Sat, 08 December 2018 17:00 Go to previous messageGo to next message
peterh is currently offline  peterh
Messages: 46
Registered: November 2018
Location: Germany
Member
Exclamation() crashes TheIde, when called inside Pdb::Stop().
Possibly this is a non GUI thread and it must be locked, but I dont know.

So I have built in extensive logging, I log all return values.

I cannot tell more news, because it did yet not happen again with the aforementioned code modification.
Re: I keep getting the same "cannot open exe for writing" error... [message #50713 is a reply to message #50712] Sat, 08 December 2018 18:33 Go to previous messageGo to next message
peterh is currently offline  peterh
Messages: 46
Registered: November 2018
Location: Germany
Member
Now it happened again.

DebugActiveProcessStop returned false, this means it failed.
Probably the debugger could not detach.
In turn, TerminateProcess failed.

"terminated flag" = terminated flag
terminated = false //This is OK
"DebugActiveProcessStop" = DebugActiveProcessStop
retval = 0x0 //Boolean, Failed
"TerminateProcess" = TerminateProcess
retval = 0x0 //Boolean, Failed
"WaitForSingleObject" = WaitForSingleObject
retval = 0x102 //WAIT_TIMEOUT
"CloseHandle" = CloseHandle
retval = 0x1 //Succeeded

[Updated on: Sat, 08 December 2018 18:47]

Report message to a moderator

Re: I keep getting the same "cannot open exe for writing" error... [message #50717 is a reply to message #50712] Sat, 08 December 2018 19:27 Go to previous messageGo to next message
peterh is currently offline  peterh
Messages: 46
Registered: November 2018
Location: Germany
Member
New Code:
void Pdb::Stop()
{
	DWORD retval;
	LOG("---------------------------------------");
	LOG("terminated flag");
	DUMP(terminated);
	if(!terminated) {
		terminated = true;
		SaveTree();
		String fn = ConfigFile("TreeTypes.txt");
		FileOut out(fn);
		for(int i = 0; i < treetype.GetCount(); i++)
			out << treetype.GetKey(i) << "\r\n" << treetype[i] << "\r\n";
		StringStream ss;
		Store(callback(this, &Pdb::SerializeSession), ss);
		WorkspaceConfigData("pdb-debugger") = ss;
		if(hProcess == INVALID_HANDLE_VALUE)
          { LOG("hProcess Handle is invalid handle value");};

		if(hProcess != INVALID_HANDLE_VALUE) {
			LOG("DebugActiveProcessStop");
			for(int i=0; i<10; i++){
				if (retval = DebugActiveProcessStop(processid)) break;
				DUMPHEX(retval);
            	                Sleep(100);
			}
			DUMPHEX(retval);
			
			retval = TerminateProcess(hProcess, 0);
			LOG("TerminateProcess");
			DUMPHEX(retval);
			retval = WaitForSingleObject(hProcess,10000);
			LOG("WaitForSingleObject");
			DUMPHEX(retval);
#ifdef NEVEREVER
			retval = MsgWaitForMultipleObjects(
							1, 			//DWORD        nCount,
							&hProcess, 	//const HANDLE *pHandles,
							true, 		//BOOL         fWaitAll,
							10000, 		//DWORD        dwMilliseconds,
							0  			//DWORD        dwWakeMask
							);
			LOG("WaitForMultibleObjects");
			DUMPHEX(retval);
#endif
			while(threads.GetCount())
				RemoveThread(threads.GetKey(0)); // To CloseHandle
			UnloadModuleSymbols();
			SymCleanup(hProcess);
			retval = CloseHandle(hProcess);
			LOG("CloseHandle");
			DUMPHEX(retval);
		}
		StoreToGlobal(*this, CONFIGNAME);
		IdeRemoveBottom(*this);
		IdeRemoveRight(disas);
	}
}

[Updated on: Sat, 08 December 2018 19:29]

Report message to a moderator

Re: I keep getting the same "cannot open exe for writing" error... [message #50718 is a reply to message #50717] Sat, 08 December 2018 19:50 Go to previous messageGo to next message
peterh is currently offline  peterh
Messages: 46
Registered: November 2018
Location: Germany
Member
Apparently it happened again.
This time however, with the new code and it worked as intended.
But not completely, because TerminateProcess failed.
Possibly the process was already terminated, because WaitForSingleObject
succeeded with retval == WAIT_OBJECT_0.

Any way, TheIde had no problem after this.

---------------------------------------
terminated flag
terminated = false
DebugActiveProcessStop
retval = 0x0
retval = 0x1
TerminateProcess
retval = 0x0
WaitForSingleObject
retval = 0x0
CloseHandle
retval = 0x1

[Updated on: Sat, 08 December 2018 19:58]

Report message to a moderator

Re: I keep getting the same "cannot open exe for writing" error... [message #50720 is a reply to message #50718] Sun, 09 December 2018 10:01 Go to previous messageGo to next message
mirek is currently offline  mirek
Messages: 11963
Registered: November 2005
Ultimate Member
So if I understand correctly, the key ingredient is to retry the DebugActiveProcessStop ?
Re: I keep getting the same "cannot open exe for writing" error... [message #50722 is a reply to message #50720] Sun, 09 December 2018 11:07 Go to previous messageGo to next message
peterh is currently offline  peterh
Messages: 46
Registered: November 2018
Location: Germany
Member
Yes, this where my findings.

The solution is, if it fails then wait 100 ms.
So the debugee can run and hopefully comes to a state where it succeeds.
In all normal cases this should work at the 2nd try.

The long timeouts are only for non-normal problem cases which we hopefully never will have. Rolling Eyes

Edit:
I did not expect this. I simply logged the results of all system calls and then did see it.

Then however, it was clear to me:
In all cases previously known to me the process could not be removed with the taskmanager.
The reason is, because the debugger is still attached.
So this must be the general reason.

[Updated on: Sun, 09 December 2018 13:54]

Report message to a moderator

Re: I keep getting the same "cannot open exe for writing" error... [message #50821 is a reply to message #50651] Fri, 04 January 2019 09:42 Go to previous messageGo to previous message
koldo is currently offline  koldo
Messages: 2966
Registered: August 2008
Veteran
Yes, it follows failing Sad

Best regards
IƱaki
Previous Topic: error: expected unqualified-id before '=' token
Next Topic: clang or MinGW
Goto Forum:
  


Current Time: Tue Jul 23 02:58:13 CEST 2019

Total time taken to generate the page: 0.01363 seconds