Overview
Examples
Screenshots
Comparisons
Applications
Download
Documentation
Tutorials
Bazaar
Status & Roadmap
FAQ
Authors & License
Forums
Funding Ultimate++
Search on this site
Search in forums












SourceForge.net Logo
Home » U++ Library support » ScatterDraw & ScatterCtrl » Compilation of ScatterDraw cause warnings (Should be fixed before 2019.1)
Compilation of ScatterDraw cause warnings [message #51493] Wed, 03 April 2019 20:44 Go to next message
Klugier is currently offline  Klugier
Messages: 1076
Registered: September 2012
Location: Poland, Kraków
Senior Contributor
Hello,

Our latest changes in build methods (We added -Wall flags that enables a lot of additional warnings) there are a lot of errors related to Scatter. I tested with ScatterCtrl_Demo. Here is the list:
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (717): warning: 'Upp::TableData::areas' will be initialized after [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/ScatterDraw.h (6): In file included from /home/klugier/upp/uppsrc/ScatterDraw/ScatterDraw.h:6,
/home/klugier/upp/uppsrc/ScatterCtrl/ScatterCtrl.h (4): from /home/klugier/upp/uppsrc/ScatterCtrl/ScatterCtrl.h:4,
/home/klugier/upp/uppsrc/ScatterCtrl/ScatterCtrl.cpp (1): from /home/klugier/upp/uppsrc/ScatterCtrl/ScatterCtrl.cpp:1:
 (): bool areas;
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (712): warning:   'int Upp::TableData::lendata' [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (671): warning:   when initialized here [-Wreorder]
/home/klugier/upp/uppsrc/ScatterCtrl/ScatterCtrl.cpp (385): warning: unused variable 'posx' [-Wunused-variable]
/home/klugier/upp/uppsrc/ScatterCtrl/ScatterCtrl.cpp (386): warning: unused variable 'posy' [-Wunused-variable]
/home/klugier/upp/uppsrc/ScatterCtrl/ScatterCtrl.cpp (387): warning: unused variable 'dx' [-Wunused-variable]
/home/klugier/upp/uppsrc/ScatterCtrl/ScatterCtrl.cpp (388): warning: unused variable 'dy' [-Wunused-variable]
/home/klugier/upp/uppsrc/ScatterCtrl/ScatterCtrl.cpp (759): warning: enumeration value 'NONE' not handled in switch [-Wswitch]
/home/klugier/upp/uppsrc/ScatterCtrl/ScatterCtrl.cpp (759): warning: enumeration value 'LEFT_UP' not handled in switch [-Wswitch]
/home/klugier/upp/uppsrc/ScatterCtrl/ScatterCtrl.cpp (759): warning: enumeration value 'LEFT_DOUBLE' not handled in switch [-Wswitch]
/home/klugier/upp/uppsrc/ScatterCtrl/ScatterCtrl.cpp (759): warning: enumeration value 'LEFT_MOVE' not handled in switch [-Wswitch]
/home/klugier/upp/uppsrc/ScatterCtrl/ScatterCtrl.cpp (759): warning: enumeration value 'MIDDLE_UP' not handled in switch [-Wswitch]
/home/klugier/upp/uppsrc/ScatterCtrl/ScatterCtrl.cpp (759): warning: enumeration value 'MIDDLE_MOVE' not handled in switch [-Wswitch]
/home/klugier/upp/uppsrc/ScatterCtrl/ScatterCtrl.cpp (759): warning: enumeration value 'RIGHT_UP' not handled in switch [-Wswitch]
/home/klugier/upp/uppsrc/ScatterCtrl/ScatterCtrl.cpp (759): warning: enumeration value 'RIGHT_MOVE' not handled in switch [-Wswitch]
/home/klugier/upp/uppsrc/ScatterDraw/ScatterDraw.h (1661): warning: enumeration value 'ALIGN_NULL' not handled in switch [-Wswitch]
/home/klugier/upp/uppsrc/ScatterDraw/ScatterDraw.h (1661): warning: enumeration value 'ALIGN_JUSTIFY' not handled in switch [-Wswitch]
/home/klugier/upp/uppsrc/ScatterDraw/ScatterDraw.h (1408): warning: unused variable 'r' [-Wunused-variable]
/home/klugier/upp/uppsrc/ScatterDraw/ScatterDraw.h (1448): warning: unused variable 'x_c' [-Wunused-variable]
/home/klugier/upp/uppsrc/ScatterDraw/ScatterDraw.h (1449): warning: unused variable 'y_c' [-Wunused-variable]
/home/klugier/upp/uppsrc/ScatterDraw/ScatterDraw.h (1661): warning: enumeration value 'ALIGN_NULL' not handled in switch [-Wswitch]
/home/klugier/upp/uppsrc/ScatterDraw/ScatterDraw.h (1661): warning: enumeration value 'ALIGN_JUSTIFY' not handled in switch [-Wswitch]
/home/klugier/upp/uppsrc/ScatterDraw/ScatterDraw.h (1408): warning: unused variable 'r' [-Wunused-variable]
/home/klugier/upp/uppsrc/ScatterDraw/ScatterDraw.h (1448): warning: unused variable 'x_c' [-Wunused-variable]
/home/klugier/upp/uppsrc/ScatterDraw/ScatterDraw.h (1449): warning: unused variable 'y_c' [-Wunused-variable]
/home/klugier/upp/uppsrc/ScatterDraw/ScatterDraw.h (1661): warning: enumeration value 'ALIGN_NULL' not handled in switch [-Wswitch]
/home/klugier/upp/uppsrc/ScatterDraw/ScatterDraw.h (1661): warning: enumeration value 'ALIGN_JUSTIFY' not handled in switch [-Wswitch]
/home/klugier/upp/uppsrc/ScatterDraw/ScatterDraw.h (1408): warning: unused variable 'r' [-Wunused-variable]
/home/klugier/upp/uppsrc/ScatterDraw/ScatterDraw.h (1448): warning: unused variable 'x_c' [-Wunused-variable]
/home/klugier/upp/uppsrc/ScatterDraw/ScatterDraw.h (1449): warning: unused variable 'y_c' [-Wunused-variable]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (717): warning: 'Upp::TableData::areas' will be initialized after [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (712): warning:   'int Upp::TableData::lendata' [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (671): warning:   when initialized here [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (717): warning: 'Upp::TableData::areas' will be initialized after [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (712): warning:   'int Upp::TableData::lendata' [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (671): warning:   when initialized here [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (717): warning: 'Upp::TableData::areas' will be initialized after [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (712): warning:   'int Upp::TableData::lendata' [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (671): warning:   when initialized here [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (717): warning: 'Upp::TableData::areas' will be initialized after [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (712): warning:   'int Upp::TableData::lendata' [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (671): warning:   when initialized here [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (717): warning: 'Upp::TableData::areas' will be initialized after [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (712): warning:   'int Upp::TableData::lendata' [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (671): warning:   when initialized here [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (717): warning: 'Upp::TableData::areas' will be initialized after [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (712): warning:   'int Upp::TableData::lendata' [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (671): warning:   when initialized here [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (717): warning: 'Upp::TableData::areas' will be initialized after [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (712): warning:   'int Upp::TableData::lendata' [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (671): warning:   when initialized here [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (717): warning: 'Upp::TableData::areas' will be initialized after [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (712): warning:   'int Upp::TableData::lendata' [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (671): warning:   when initialized here [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (717): warning: 'Upp::TableData::areas' will be initialized after [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (712): warning:   'int Upp::TableData::lendata' [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (671): warning:   when initialized here [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (717): warning: 'Upp::TableData::areas' will be initialized after [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (712): warning:   'int Upp::TableData::lendata' [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (671): warning:   when initialized here [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (717): warning: 'Upp::TableData::areas' will be initialized after [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (712): warning:   'int Upp::TableData::lendata' [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (671): warning:   when initialized here [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (717): warning: 'Upp::TableData::areas' will be initialized after [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (712): warning:   'int Upp::TableData::lendata' [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (671): warning:   when initialized here [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (717): warning: 'Upp::TableData::areas' will be initialized after [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (712): warning:   'int Upp::TableData::lendata' [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (671): warning:   when initialized here [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (717): warning: 'Upp::TableData::areas' will be initialized after [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (712): warning:   'int Upp::TableData::lendata' [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (671): warning:   when initialized here [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (717): warning: 'Upp::TableData::areas' will be initialized after [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (712): warning:   'int Upp::TableData::lendata' [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (671): warning:   when initialized here [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (717): warning: 'Upp::TableData::areas' will be initialized after [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (712): warning:   'int Upp::TableData::lendata' [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (671): warning:   when initialized here [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (717): warning: 'Upp::TableData::areas' will be initialized after [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (712): warning:   'int Upp::TableData::lendata' [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (671): warning:   when initialized here [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (717): warning: 'Upp::TableData::areas' will be initialized after [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (712): warning:   'int Upp::TableData::lendata' [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (671): warning:   when initialized here [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (717): warning: 'Upp::TableData::areas' will be initialized after [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (712): warning:   'int Upp::TableData::lendata' [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (671): warning:   when initialized here [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (717): warning: 'Upp::TableData::areas' will be initialized after [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (712): warning:   'int Upp::TableData::lendata' [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (671): warning:   when initialized here [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (717): warning: 'Upp::TableData::areas' will be initialized after [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (712): warning:   'int Upp::TableData::lendata' [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (671): warning:   when initialized here [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (717): warning: 'Upp::TableData::areas' will be initialized after [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (712): warning:   'int Upp::TableData::lendata' [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.h (671): warning:   when initialized here [-Wreorder]
/home/klugier/upp/uppsrc/ScatterDraw/DataSource.cpp (848): warning: this 'if' clause does not guard... [-Wmisleading-indentation]
/home/klugier/upp/uppsrc/ScatterDraw/Legend.cpp (142): warning: enumeration value 'TOP' not handled in switch [-Wswitch]
/home/klugier/upp/uppsrc/ScatterDraw/ScatterDraw.h (1661): warning: enumeration value 'ALIGN_NULL' not handled in switch [-Wswitch]
/home/klugier/upp/uppsrc/ScatterDraw/ScatterDraw.h (1661): warning: enumeration value 'ALIGN_JUSTIFY' not handled in switch [-Wswitch]
/home/klugier/upp/uppsrc/ScatterDraw/ScatterDraw.h (1408): warning: unused variable 'r' [-Wunused-variable]
/home/klugier/upp/uppsrc/ScatterDraw/ScatterDraw.h (1448): warning: unused variable 'x_c' [-Wunused-variable]
/home/klugier/upp/uppsrc/ScatterDraw/ScatterDraw.h (1449): warning: unused variable 'y_c' [-Wunused-variable]
/home/klugier/upp/uppsrc/ScatterDraw/ScatterDraw.h (1661): warning: enumeration value 'ALIGN_NULL' not handled in switch [-Wswitch]
/home/klugier/upp/uppsrc/ScatterDraw/ScatterDraw.h (1661): warning: enumeration value 'ALIGN_JUSTIFY' not handled in switch [-Wswitch]
/home/klugier/upp/uppsrc/ScatterDraw/ScatterDraw.h (1408): warning: unused variable 'r' [-Wunused-variable]
/home/klugier/upp/uppsrc/ScatterDraw/ScatterDraw.h (1448): warning: unused variable 'x_c' [-Wunused-variable]
/home/klugier/upp/uppsrc/ScatterDraw/ScatterDraw.h (1449): warning: unused variable 'y_c' [-Wunused-variable]


Koldo, it would be nice if we manage to fix that issues before release.

Sincerely,
Klugier


U++ - one framework to rule them all.
Re: Compilation of ScatterDraw cause warnings [message #51499 is a reply to message #51493] Fri, 05 April 2019 09:25 Go to previous messageGo to next message
koldo is currently offline  koldo
Messages: 3356
Registered: August 2008
Senior Veteran
Hi Klugier

I have fixed it with MinGW (I do not know if the version you use generates more warnings).

Big surprise as I use "pedantic" with no warning, and U++ unfortunately generates tons of warnings.

It seems "all" is stronger than "pedantic".


Best regards
Iñaki
Re: Compilation of ScatterDraw cause warnings [message #51506 is a reply to message #51499] Sat, 06 April 2019 15:17 Go to previous messageGo to next message
koldo is currently offline  koldo
Messages: 3356
Registered: August 2008
Senior Veteran
After compiling in Linux, I have found and fixed last warnings.

Klugier: Please solve Core warnings. They are not much but, but being in Core, they appear repeatedly.
I have been compiling with "pedantic" for years and having continuously those warnings has been unpleasant.


Best regards
Iñaki
Re: Compilation of ScatterDraw cause warnings [message #51507 is a reply to message #51506] Sun, 07 April 2019 11:16 Go to previous messageGo to next message
Klugier is currently offline  Klugier
Messages: 1076
Registered: September 2012
Location: Poland, Kraków
Senior Contributor
Hello Koldo,

I can confirm that warnings gone away. Thanks for fixing this!

Backing to pedantic flag - I can not commit to Core directory. So, I am probably not good person to solve that issue. You should ask Mirek. However, I think that pedantic mode is too strong to officially introduce it to U++ default build methods. When I compiled TheIDE it mainly warns that there is additional ";", which field of destruction is very small.

Sincerely,
Klugier


U++ - one framework to rule them all.
Re: Compilation of ScatterDraw cause warnings [message #52312 is a reply to message #51507] Wed, 04 September 2019 12:32 Go to previous message
koldo is currently offline  koldo
Messages: 3356
Registered: August 2008
Senior Veteran
Code now tested with these gcc flags:
"-Wall"
"-Wextra"
"-Wpedantic"
"-Wcast-align"
"-Wcast-qual"
"-Wctor-dtor-privacy"
"-Wdisabled-optimization"
"-Wformat=2"
"-Winit-self"
"-Wlogical-op"
"-Wmissing-include-dirs"
"-Wnoexcept"
"-Wold-style-cast"
"-Wredundant-decls"
"-Wshadow"
"-Wsign-promo"
"-Wstrict-null-sentinel"
"-Wstrict-overflow=4"
"-Wundef"
"-Wunused-variable"


Best regards
Iñaki
Previous Topic: [Bug] Text overflows legend box (RESOLVED)
Next Topic: [solved] ScatterCtrl: program access to the "Measures" ?
Goto Forum:
  


Current Time: Tue Apr 16 09:54:30 CEST 2024

Total time taken to generate the page: 0.02661 seconds