Hello,

I had the discussion with Mirek about this article https://evileg.com/en/post/629/ he found that the user uses deprecated THISBACK construction. Well we deprecated it in the documentation in favor or lambdas or newer c++ constructions such as Function, Gate etc.

In c++14 which we targets on all platforms the solution is easy. We can deprecate it on compilation level, which means something. Just mark THISBACK with deprecated atribute like this:

[[deprecated("THISBACK is deprecated use lambda instead.")]]
const int thisbackd = 0;

#define THISBACK(x)                  callback(this  + thisbackd, &CLASSNAME::x)
#define THISBACK1(x, arg)            callback1(this + thisbackd, &CLASSNAME::x, arg)
#define THISBACK2(m, a, b)           callback2(this + thisbackd, &CLASSNAME::m, a, b)
#define THISBACK3(m, a, b, c)        callback3(this + thisbackd, &CLASSNAME::m, a, b, c)
#define THISBACK4(m, a, b, c, d)     callback4(this + thisbackd, &CLASSNAME::m, a, b, c, d)
#define THISBACK5(m, a, b, c, d, e)  callback5(this + thisbackd, &CLASSNAME::m, a, b, c, d,e)

Then in all places when THISBACK is used the warning pop up "/home/klugier/upp/uppsrc/CtrlLib/FileSel.h (239): warning: 'thisbackd' is deprecated: THISBACK is deprecated use lambda instead. [-Wdeprecated-declarations]".

I think we have multiple places when [[deprecated]] macro can be used. If you search for "deprecated" in uppsrc then there is around 52 entries... Definitely not the topic for 2020.2, but for 2021.1...

Klugier

Hello Mirek,

I like your message - it is funny This is the task for student or someone who would like to help in terms of uppsrc. I can imagine first job in coputer software industry when you need to replace THISBACK with lambda You are doing this for your tow weeks, but finally you are proud of yourself that you manage to do it.

Hello,

Backing to this problem. I see that several templates (.upt) have CLASSNAME declaration. From my perspective the good idea would be to remove that declaration. After that all new code shouldn't have dependency to THISBACK:

CtrlLib/Complex.upt:

...
class <:classname:> : public <:lay > 1 ? "With" + classname + "Layout<TopWindow>" : "TopWindow":> {
public:
	typedef <:classname:> CLASSNAME;
	<:classname:>();
};
...

Could be:

...
class <:classname:> : public <:lay > 1 ? "With" + classname + "Layout<TopWindow>" : "TopWindow":> {
public:
	<:classname:>();
};
...

Skylark and Tutrle templates are also affected...

Klugier

THISBACK is deprecated. In U++ that does usually mean it will most likely be supported for ever, but there are better options now (lambdas).

Mirek

Hello MeerMusik,

Yes, you should use lambdas instead of THISBACK for creating menus. Last year, I updated our GUI tutorial to illustrate these changes. Please, check all topics related to menus:
- 7. Menu (Also 8, 9 & 10 are valuable)
- 11. Toolbar

Klugier