Hello Mirek,

2) The light breeze-gtk theme on Manjaro for menu bar is broken. It means that top menu bar works correctly, but nested are not. I attached screenshot to show this issue. Left is upp, right is LibreOffice that handles it correctly.

In above text the menu item text should be black not white. Also, the new/updated styling algorith should do not break topiteam text. This might requires bigger reworked.

Klugier

Hello Mirek,

I found two issues

1) the first one is related to next/back stack for TheIDE build in help. It means that when you click on some entry for example "Assist++" you can not back to initial help menu. There are also problems with table of contents, it doesn't work in that view.

Also, when you open help for the first time after launching TheIDE it has back entry. It shouldn't be there and the stack should be empty.

Please test you, I believe you should find all mentioned issues pretty quickly.

Hello Mirek,

The issue has been fixed for Breeze Light and Dark. Thank you for that! You also forget to remove debug code in production (line 513 - ChGtk4.cpp):

PNGEncoder().SaveFile("/home/cxl/item.png", item);

For other themes, I noticed that there is a issue for Adwaita (KDE Gtk Theme). The bar text should be white instead of black. I attached U++ (left) comparison with Chrom (right).


Klugier

int Diff(RGBA a, RGBA b)
{
	return max(abs(a.a - b.a), max(abs(a.r - b.r) / 2, max(abs(a.b - b.b) / 5, abs(a.g - b.g))));
}

Hello Mirek,

Alternative diff method doesn't help in this case. For the log in ChGtk3.cpp file:

"Start" = Start
"Before if" = Before if
c = Color(241, 246, 253)
s.itemtext = Color(255, 255, 255)
Diff(c, s.itemtext) = 9
"After if" = After if
c = Color(241, 246, 253)
s.itemtext = Color(0, 0, 0)
Diff(c, s.itemtext) = 246
"End" = End

Klugier

Another test code for failing configurable key parser:

	String s1 = "1;\n";
	String s2 = "1;";
	String s3 = "1";

	uint32 i = CParser(s1).ReadNumber(16);
	RLOG("1) Base 16: " << i);
	uint32 j = CParser(s1).ReadNumber(10);
	RLOG("1) Base 10: " << j);
	
	RLOG("-----");
	
	uint32 k = CParser(s2).ReadNumber(16);
	RLOG("2) Base 16: " << k);
	uint32 l = CParser(s2).ReadNumber(10);
	RLOG("2) Base 10: " << l);

	RLOG("-----");

	uint32 m = CParser(s3).ReadNumber(16);
	RLOG("3) Base 16: " << m);
	uint32 n = CParser(s3).ReadNumber(10);
	RLOG("3) Base 10: " << n);
	

Results:

1) Base 16: 20
1) Base 10: 1
-----
2) Base 16: 20
2) Base 10: 1
-----
3) Base 16: 1
3) Base 10: 1

Seems that CParser.GetNumber(16) is not reading the number correctly.

Best regards,
Oblivion

Hello Mirek,

After your last commit everything works as expected. I also tested other themes for regression, but they behave as expected. Thank you! Now, TheIDE help stabilization is waiting

Klugier

Klugier wrote on Sun, 21 May 2023 20:53

Hello Mirek,

After your last commit everything works as expected. I also tested other themes for regression, but they behave as expected. Thank you! Now, TheIDE help stabilization is waiting

Klugier

I have commited the fix yesterday, perhaps you missed it, or is is still in need of "stabilisation"?

mirek wrote on Mon, 22 May 2023 09:42

Klugier wrote on Sun, 21 May 2023 20:53

Hello Mirek,

After your last commit everything works as expected. I also tested other themes for regression, but they behave as expected. Thank you! Now, TheIDE help stabilization is waiting

Klugier

I have commited the fix yesterday, perhaps you missed it, or is is still in need of "stabilisation"?

Hello Mirek,

Everything works fine. I wrote my message after using your last commit from yesterday. We can assume for now that GTK menubar styling works as expected.

Klugier