U++ forum: Welcome to the forum

Search on this site

Search in forums

Home » U++ Library support » U++ Core » Possible inconsistency with Rect::Contains() right-bottom bounds?

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Possible inconsistency with Rect::Contains() right-bottom bounds? [message #53038]

Sun, 16 February 2020 13:06

Oblivion
Messages: 1092
Registered: August 2007

Senior Contributor

Hello,

I've noticed that:

template <class T>
bool Rect_<T>::Contains(T x, T y) const {
	return x >= left && x < right && y >= top && y < bottom;
}                            ---                      ---
                              x                        x
template <>
inline bool Rect_<double>::Contains(double x, double y) const {
	return x >= left && x <= right && y >= top && y <= bottom;
}                             ---                       ---
                               ^                         ^

template <class T>
bool Rect_<T>::Contains(const Rect_<T>& r) const {
	return r.left >= left && r.top >= top && r.right <= right && r.bottom <= bottom;
}                                                        ---                 ---
                                                          ^                    ^

Best regards,
Obiivion

Github page: https://github.com/ismail-yilmaz
upp-components: https://github.com/ismail-yilmaz/upp-components
Bobcat the terminal emulator: https://github.com/ismail-yilmaz/Bobcat

Report message to a moderator

Re: Possible inconsistency with Rect::Contains() right-bottom bounds? [message #53040 is a reply to message #53038]

Sun, 16 February 2020 19:04

mirek
Messages: 13975
Registered: November 2005

Ultimate Member

Oblivion wrote on Sun, 16 February 2020 13:06

Hello,

I've noticed that:

template <class T>
bool Rect_<T>::Contains(T x, T y) const {
	return x >= left && x < right && y >= top && y < bottom;
}                            ---                      ---
                              x                        x
template <>
inline bool Rect_<double>::Contains(double x, double y) const {
	return x >= left && x <= right && y >= top && y <= bottom;
}                             ---                       ---
                               ^                         ^

template <class T>
bool Rect_<T>::Contains(const Rect_<T>& r) const {
	return r.left >= left && r.top >= top && r.right <= right && r.bottom <= bottom;
}                                                        ---                 ---
                                                          ^                    ^

Best regards,
Obiivion

Thats intentional. It might be inconsistent, but for doubles it is better to include bottom-right corner into the rectangle.

Mirek

Report message to a moderator