|
|
|
|
| Re: Patch: Highlight Errors [message #9544 is a reply to message #9542] |
Wed, 16 May 2007 09:12   |
|
|
| Quote: |
(Unfortunately i have not found the place in the source where the default colors are defined, ... and the default color is now "transparent" )
|
Ok. It's here in void CodeEditor::DefaultHlStyles()
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Re: Patch: Highlight Errors [message #9559 is a reply to message #9558] |
Wed, 16 May 2007 23:17   |
|
|
| Quote: |
But I would prefer to have them allways slightly visible.
|
yes, you're right - that's what I thought but not wrote.
| Quote: |
But if necessary I could add a hot key and/or toolbar icon.
|
That and option in configuration dialog to disable this future completely. Probably there is someone who doesn't like it 
| Quote: |
I'm interested in you quicktabs! This was another point which I consider improveable beside some other small things.
|
Just wait a few days. Concentrate on those small things Later we can improve my tabs if somthing missing/not working as expected.
| Quote: |
Well, and what I really would like to have are some basic refractoring functions like renaming a class, function, etc.
But I guess I have to collect some more experion points with Ultimate++ before thinking about implementing it, but on the other hand the internal parser and the functionality from assist seems to be allready enough to try to implement it.
|
That would be fantastic!
I thought also about functions like add class (from user templates) to the project, add dialog to the project (this should add dialog.h dialog.cpp and dialog.lay files) etc.
If Mirek would implement block operations and improve c++ parser theide would be the best in the market
|
|
|
|
|
|
| Re: Patch: Highlight Errors [message #9580 is a reply to message #9579] |
Thu, 17 May 2007 22:42   |
|
|
| Quote: | The aging of the edit marker works, now. Plus some small bugfix, some files were marked edited, even if there was no edit
|
I also noticed a bug when one undo changes. Markers should be cleared then.
| Quote: | So I would suggest:
One hot key to clear all markers in all files. No toolbar icon.
One option in the settings to disable the edit /errors / warning markers together.
|
I agree + hotkey to clear markers in one file.
|
|
|
|
|
|
|
|
|
|
| Re: Patch: Highlight Errors [message #9593 is a reply to message #9581] |
Fri, 18 May 2007 16:08   |
Zardos
Messages: 62 Registered: April 2007
|
Member |
|
|
Here is the new patch for the edit markers.
* bugfix: Some files ware marked edited, even if there was no edit
* bugfix: If editor window is split: In Editor2 all lines were marked as edited
* Edit markes slowly blend out with each edit (I prefered this over aging them with each save)
* Edit / Error / Warning markers can now switched of in Settings-Editor
* Hot Keys and entry in Edit-Menu: I added a third option: Remove Markers for selection. Menu entries will disapear if Markers are turned of via Settings. I didn't know how to add a hot key without generating a menu entry... But may be its good to have it in the menu, anyway.
Undo bug is still not fixed...
I will try to change the "edit markers" to "change markers".
I think I have found a way to track the changes and mark all changed /new / deleted lines with it's own color without wasting much memory and cpu-cycles. This would solve the undo problem, too. In addition there would be the possibility to select some changed lines and revert to the original lines with a hot key. Similar to an undo for selected lines. The revert to original lines operation would be stored in the general undo history. So you can still do a complete undo of the file, even if you have performed a revert opertaion for some lines.
[Updated on: Fri, 18 May 2007 16:15] Report message to a moderator
|
|
|
|
|
|
| Re: Patch: Highlight Errors [message #9618 is a reply to message #9616] |
Tue, 22 May 2007 00:36   |
Zardos
Messages: 62 Registered: April 2007
|
Member |
|
|
| unodgs wrote on Mon, 21 May 2007 22:05 | Thanks! I merged the patch. I really like these markers 
|
Thanks!
Here comes the update (patch is based on revision 58).
I gave up on tracing the changes instead of the edits...
Instead the following changes:
* UNDO removes the edit markers, now! Was a lot of work!
* Removed "Remove change markers from Selection" in menu and hot keys, because I considered it not very useful.
* Find in Files marks the line where the search term occurs in green.
- Ralf
[Updated on: Tue, 22 May 2007 01:05] Report message to a moderator
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| Re: Patch: Highlight Errors [message #9661 is a reply to message #9659] |
Thu, 24 May 2007 08:32   |
|
|
| Quote: | While doing the merge I recogniced the space between if / for and ( were removed. if () -> if()...
I will try to adapt to the upp-style. But old habbits are hard to fight
|
I feel the same about opening curly bracket in line with code...
(that remainds me I must reformat quicktabs code..)
| Quote: | Middle Click does not remove the tab, yet. But I guess you already now, this.
|
I was trying to implement that at least on win32 platform - without success (yet). The problem is Upp does not provide a common way to handle middle click. In win32 it maps middle click to left click.
|
|
|
|
| Re: Patch: Highlight Errors [message #9667 is a reply to message #9661] |
Thu, 24 May 2007 15:29   |
mrjt
Messages: 705 Registered: March 2007 Location: London
|
Contributor |
|
|
| Quote: | The problem is Upp does not provide a common way to handle middle click. In win32 it maps middle click to left click.
|
Can't you just override MouseEvent?
virtual Image MouseEvent(int event, Point p, int zdelta, dword keyflags)
{
if (keyflags & K_MOUSEMIDDLE) {
switch (event) {
case LEFTDOWN:
MiddleDown(p, keyflags);
break;
case LEFTDOUBLE:
MiddleDouble(p, keyflags);
break;
//..Etc.
default:
return Ctrl::MouseEvent(event, p, zdelta, keyflags);
}
}
else
return Ctrl::MouseEvent(event, p, zdelta, keyflags);
return Image::Arrow();
};
It definitely works on Win32, but looking at the mouse event code I can't see any reason why it wouldn't also work on X11. You could also do the keyflags check in LeftDown for the same effect.
Presumably there was a good reason for not having specific handling functions for middle clicks in Upp, but I don't know what it was.
[Updated on: Thu, 24 May 2007 15:33] Report message to a moderator
|
|
|
|
|
|
|
|
| Re: Patch: Highlight Errors [message #9672 is a reply to message #9659] |
Thu, 24 May 2007 20:25   |
Zardos
Messages: 62 Registered: April 2007
|
Member |
|
|
New ( daily ) Markers patch...
Changes:
* Bugfix: Compile Errors on MINGW
* Bugfix: Sometimes (after Build) some markers disapeared
* Bugfix: Lines containing errors sometimes marked in green instead of red
* Bugfix: Blend-color (age of marker) sometimes was wrong
* New Color for the marker: yellow-green
* Cleanups
- Ralf
[Updated on: Thu, 24 May 2007 21:33] Report message to a moderator
|
|
|
|
|
|
|
|
|
|
|
|