Overview
Examples
Screenshots
Comparisons
Applications
Download
Documentation
Tutorials
Bazaar
Status & Roadmap
FAQ
Authors & License
Forums
Funding Ultimate++
Search on this site
Search in forums












SourceForge.net Logo
Home » U++ Library support » U++ Library : Other (not classified elsewhere) » [IMPROVEMENT] GTK and Win32 backends should emulate error icon.
[IMPROVEMENT] GTK and Win32 backends should emulate error icon. [message #40449] Sat, 03 August 2013 01:26 Go to next message
Klugier is currently offline  Klugier
Messages: 636
Registered: September 2012
Location: Poland, Kraków
Contributor
Hello,

Personally, I think that GTK backend should also emulate error icon. What we need to do is just add one little line of code:

ChCtrlImg(CtrlImg::I_error, "gtk-dialog-error", 6);


I enclose improved source file.

Sincerely,
Klugier
  • Attachment: ChGtk.cpp
    (Size: 21.14KB, Downloaded 168 times)


Ultimate++ - one framework to rule them all.

[Updated on: Wed, 07 August 2013 13:59]

Report message to a moderator

Re: [IMPROVEMENT] GTK backend should emulate error icon. [message #40454 is a reply to message #40449] Sat, 03 August 2013 14:22 Go to previous messageGo to next message
Klugier is currently offline  Klugier
Messages: 636
Registered: September 2012
Location: Poland, Kraków
Contributor
Hello,

We need to improvement Win32 version too. Here is the new line of code (CtrlLib/ChWin32.cpp - line 613):

CtrlImg::Set(CtrlImg::I_error, Win32Icon(IDI_ERROR));


Moreover, I enclose source file.

Sincerely,
Klugier
  • Attachment: ChWin32.cpp
    (Size: 18.00KB, Downloaded 182 times)


Ultimate++ - one framework to rule them all.
Re: [IMPROVEMENT] GTK backend should emulate error icon. [message #40545 is a reply to message #40454] Sun, 11 August 2013 14:50 Go to previous messageGo to next message
mirek is currently offline  mirek
Messages: 12096
Registered: November 2005
Ultimate Member
Interestingly, CtrlImg::error is not used anywhere... Should not we rather delete it?
Re: [IMPROVEMENT] GTK backend should emulate error icon. [message #40546 is a reply to message #40545] Sun, 11 August 2013 15:02 Go to previous messageGo to next message
Klugier is currently offline  Klugier
Messages: 636
Registered: September 2012
Location: Poland, Kraków
Contributor
Hello Mirek,

In my opinion we shoudn't delete CtrlImg::error. It can still be used in third party applications!

Moreover I think that, we can add function like ErrorOK. (Based on Prompt but with error image). For example:

void ErrorOK(const char *qtf) {
	BeepError(); // <- Firstly, we need to implement this function!
	Prompt(Ctrl::GetAppName(), CtrlImg::error(), qtf, t_("OK"));
}


Sincerely,
Klugier


Ultimate++ - one framework to rule them all.

[Updated on: Sun, 11 August 2013 15:08]

Report message to a moderator

Re: [IMPROVEMENT] GTK backend should emulate error icon. [message #40574 is a reply to message #40546] Sat, 17 August 2013 17:58 Go to previous message
mirek is currently offline  mirek
Messages: 12096
Registered: November 2005
Ultimate Member
OK, patch applied.

Mirek
Previous Topic: [IMPROVEMENT - WIN32] TreeCtrl should use native icons (open and close).
Next Topic: [bug] Moved UI components on different systems
Goto Forum:
  


Current Time: Tue Nov 12 23:03:41 CET 2019

Total time taken to generate the page: 0.01367 seconds