U++ framework: U++ Core » Thread::ShutdownThreads not safe

Home » U++ Library support » U++ Core » Thread::ShutdownThreads not safe

Show: Today's Messages :: Polls :: Message Navigator
E-mail to friend

Thread::ShutdownThreads not safe [message #26951]

Sun, 13 June 2010 15:40

hojtsy
Messages: 241
Registered: January 2006
Location: Budapest, Hungary

Experienced Member

Hi,

I think the implementation of Thread::ShutdownThreads() and Thread::IsShutdownThreads() is not thread-safe:

static Atomic  sShutdown;

void Thread::ShutdownThreads()
{
	AtomicInc(sShutdown);
	while(sThreadCount)
		Sleep(100);
	AtomicDec(sShutdown);
}

bool Thread::IsShutdownThreads()
{
	return sShutdown;
}

I believe that the correct implementation would be:

static volatile Atomic  sShutdown = 0;

void Thread::ShutdownThreads()
{
	AtomicInc(sShutdown);
	while(AtomicRead(sThreadCount))
		Sleep(100);
	AtomicDec(sShutdown);
}

bool Thread::IsShutdownThreads()
{
	return AtomicRead(sShutdown);
}

Could you please look into this, and fix if I am correct.
Thanks,
- Sandor

Report message to a moderator

[Message index]

		Thread::ShutdownThreads not safe By: hojtsy on Sun, 13 June 2010 15:40
		Re: Thread::ShutdownThreads not safe By: mirek on Sun, 13 June 2010 17:54
		Re: Thread::ShutdownThreads not safe By: tojocky on Sun, 13 June 2010 20:03
		Re: Thread::ShutdownThreads not safe By: mirek on Mon, 14 June 2010 09:01

Previous Topic:	double equals nothing
Next Topic:	DeXml() incomplete

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Tue Jul 21 10:57:07 GMT+2 2026

Total time taken to generate the page: 0.00921 seconds