https://www.ultimatepp.org/redmine/https://www.ultimatepp.org/redmine/redmine/favicon.ico2011-11-13T16:43:53ZRedmineU++ - Bug #165: CodeEditor: incorrect refresh with scope highlighting enabledhttps://www.ultimatepp.org/redmine/issues/165?journal_id=3922011-11-13T16:43:53ZMiroslav Fidlercxl@ntllib.org
<ul><li><strong>Priority</strong> changed from <i>Normal</i> to <i>Urgent</i></li></ul> U++ - Bug #165: CodeEditor: incorrect refresh with scope highlighting enabledhttps://www.ultimatepp.org/redmine/issues/165?journal_id=3932011-11-13T22:32:54ZMiroslav Fidlercxl@ntllib.org
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Ready for QA</i></li><li><strong>Assignee</strong> changed from <i>Miroslav Fidler</i> to <i>Daniel Kos</i></li></ul> U++ - Bug #165: CodeEditor: incorrect refresh with scope highlighting enabledhttps://www.ultimatepp.org/redmine/issues/165?journal_id=3952011-11-15T05:01:43ZSender Ghost
<ul><li><strong>File</strong> <a href="/redmine/attachments/download/70/165_uppsrc.diff">165_uppsrc.diff</a><a href="/redmine/attachments/70/165_uppsrc.diff"><img alt="Magnifier" src="/redmine/images/magnifier.png" /></a> added</li></ul><p>I think, r4170 didn't solve this problem.<br />Incorrect scope highlighting for following source code:<br /><pre><code class="cpp syntaxhl"><span class="CodeRay"><span class="directive">void</span> test()
{
<span class="keyword">if</span>(a()) && b) <span class="comment">// <-- incorrect ')' or ']' must be ignored for correct scope highlighting</span>
{
}
}
<span class="predefined-type">int</span> main()
{
test();
<span class="keyword">return</span> <span class="integer">0</span>;
}
</span></code></pre><br />Which lead to attached patch.</p> U++ - Bug #165: CodeEditor: incorrect refresh with scope highlighting enabledhttps://www.ultimatepp.org/redmine/issues/165?journal_id=4052011-11-19T18:05:45ZMiroslav Fidlercxl@ntllib.org
<ul><li><strong>Assignee</strong> changed from <i>Daniel Kos</i> to <i>Sender Ghost</i></li></ul><p>Sender Ghost wrote:</p>
<blockquote>
<p>I think, r4170 didn't solve this problem.<br />Incorrect scope highlighting for following source code:<br />[...]<br />Which lead to attached patch.</p>
</blockquote>
<p>It is not the same issue. Original problem is repaint artifact. Whether highlightling process should "fix" incorrect braces is another problem. Personally, I like current behaviour is better, as it visually tells that something is wrong.</p>
<p>Anyway, it is not a problem if you do QA instead of Assigned person. But please, if you think the bug is not resolved, change status to New and assign back to me (or other author). This way, I have missed your patch completely...</p>
<p>Please Approve or assign to Daniel (as issue origin). Or back to me if you think you are right (you might be). I think the proper action now is perhaps adding some "Consider fixing incorrect braces in syntax HL" task, with suggested patch... (we can then negotiate whether it is a good idea at all..).</p>
<p>Mirek</p> U++ - Bug #165: CodeEditor: incorrect refresh with scope highlighting enabledhttps://www.ultimatepp.org/redmine/issues/165?journal_id=4072011-11-19T19:02:48ZSender Ghost
<ul><li><strong>Assignee</strong> changed from <i>Sender Ghost</i> to <i>Miroslav Fidler</i></li></ul> U++ - Bug #165: CodeEditor: incorrect refresh with scope highlighting enabledhttps://www.ultimatepp.org/redmine/issues/165?journal_id=4082011-11-19T19:03:30ZSender Ghost
<ul></ul><p><a class="issue tracker-1 status-6 priority-3 priority-low2 closed" href="https://www.ultimatepp.org/redmine/issues/177" title="CodeEditor: Consider fixing incorrect braces in syntax highlighting (Rejected)">#177</a></p> U++ - Bug #165: CodeEditor: incorrect refresh with scope highlighting enabledhttps://www.ultimatepp.org/redmine/issues/165?journal_id=4092011-11-19T19:05:27ZSender Ghost
<ul></ul><p><cite>Personally, I like current behaviour is better, as it visually tells that something is wrong.</cite><br />It tells with red color on braces.</p> U++ - Bug #165: CodeEditor: incorrect refresh with scope highlighting enabledhttps://www.ultimatepp.org/redmine/issues/165?journal_id=4102011-11-19T20:45:31ZSender Ghost
<ul></ul><p>Sender Ghost wrote:</p>
<blockquote>
<p>It tells with red color on <del>braces</del>.</p>
</blockquote>
<p>with <strong>red</strong> color on ')' and ']' brackets.</p> U++ - Bug #165: CodeEditor: incorrect refresh with scope highlighting enabledhttps://www.ultimatepp.org/redmine/issues/165?journal_id=4112011-11-20T17:56:32ZDaniel Kosunodgs@tlen.pl
<ul><li><strong>Status</strong> changed from <i>Ready for QA</i> to <i>Approved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul>