U++: Issueshttps://www.ultimatepp.org/redmine/https://www.ultimatepp.org/redmine/redmine/favicon.ico2019-10-09T02:20:03ZRedmine
Redmine Feature #1992 (Approved): IconDes: Line endings support for image designerhttps://www.ultimatepp.org/redmine/issues/19922019-10-09T02:20:03ZSender Ghost
<p>Similar to the current (at <a href="https://github.com/ultimatepp/mirror/commit/5a5cdb275ac0b079332f6fe07e3638347b166244" class="external">13633</a> revision) TheIDE's layout designer, the image designer uses "\r\n" line endings to save *.iml file(s) by default. As a consequence, this may affect creation of patches for *.iml file(s), which may include changes for line endings, among other things. There was a need to convert affected *.iml file(s) to previous line endings state to fix this.</p>
<p>Some examples of LF ("\n") *.iml files:<br /><a href="https://github.com/ultimatepp/mirror/blob/1f34594209f45bca6f917a2a2367c17846835a52/uppsrc/CodeEditor/CodeEditor.iml" class="external">uppsrc/CodeEditor/CodeEditor.iml</a><br /><a href="https://github.com/ultimatepp/mirror/blob/8d3d7c1f07b8cfca2334ddad869f4be86c21695c/uppsrc/CtrlCore/Ctrl.iml" class="external">uppsrc/CtrlCore/Ctrl.iml</a><br /><a href="https://github.com/ultimatepp/mirror/blob/3f86269de04ab592df026b0568d9b4b63f1c9c9b/uppsrc/IconDes/IconDes.iml" class="external">uppsrc/IconDes/IconDes.iml</a><br /><a href="https://github.com/ultimatepp/mirror/blob/544d7740f7008f080c5c9771df999005b645bd73/uppsrc/ide/ide.iml" class="external">uppsrc/ide/ide.iml</a><br /><a href="https://github.com/ultimatepp/mirror/blob/d1eba1a4bbb0040b5bf33b3e20de70e28e47507a/uppsrc/ide/LayDes/LayDes.iml" class="external">uppsrc/ide/LayDes/LayDes.iml</a></p>
<p>Some examples of CRLF ("\r\n") *.iml files:<br /><a href="https://github.com/ultimatepp/mirror/blob/0676951ef76ff1afe33682d95979ddea494624a5/uppsrc/CtrlCore/CtrlCore.iml" class="external">uppsrc/CtrlCore/CtrlCore.iml</a><br /><a href="https://github.com/ultimatepp/mirror/blob/1f34594209f45bca6f917a2a2367c17846835a52/uppsrc/TabBar/TabBar.iml" class="external">uppsrc/TabBar/TabBar.iml</a><br /><a href="https://github.com/ultimatepp/mirror/blob/c6d0d6c9c461f54c9e31aecab42fa8bb1970208f/uppsrc/XmlView/XmlView.iml" class="external">uppsrc/XmlView/XmlView.iml</a><br /><a href="https://github.com/ultimatepp/mirror/blob/2369e19af1133d2c8f16ef884ba34f661915b4c6/uppsrc/ide/MacroManager/MacroManager.iml" class="external">uppsrc/ide/MacroManager/MacroManager.iml</a><br /><a href="https://github.com/ultimatepp/mirror/blob/15cc14a16f205ee863e2a4221df25c49ddf803a5/uppsrc/urepo/urepo.iml" class="external">uppsrc/urepo/urepo.iml</a></p>
<p>I propose to detect known line endings for TheIDE's image designer, which are used to save *.iml file(s).</p> Bug #1959 (Approved): RGBACtrl doesn't scale well (no UHD support)https://www.ultimatepp.org/redmine/issues/19592019-05-05T19:57:27ZZbigniew Rebacz
<p>Insert color dialog from TheIDE on my full hd monitor is cutted. Probably the problem is related to this method:<br /><pre>
void RGBACtrl::Layout()
{
Size sz = GetSize();
int ah = IconDesImg::Alpha().GetHeight() + 20;
int th = text.GetStdHeight(text.GetFont());
int eh = 4 - 20 - ah - th - 4;
int rh = min(sz.cx - (sz.cx >> 3), sz.cy - eh);
ramp.BottomPos(0, rh).HSizePos();
int y = sz.cy - rh - 4 - ah;
alpha.TopPos(y, ah).HSizePos(1, 0);
text.TopPos((y -= 4 + th), th).HSizePos(1, 0);
cbox.cx = (sz.cx - 3) / 18;
cbox.cy = minmax(cbox.cx, 4, Zy(16));
int ch = 14 * cbox.cy;
cs.x = (sz.cx - 18 * cbox.cx) / 2 + 1;
cs.y = (y -= ch + 4);
if(subctrl)
subctrl->TopPos(0, y - 4).HSizePos(1, 0);
}
// or this one:
void RGBACtrl::Paint(Draw& w)
{
w.DrawRect(GetSize(), SColorFace);
if(alpha.IsMask())
return;
for(int x = 0; x <= 18; x++)
w.DrawRect(x * cbox.cx + cs.x, cs.y, 1, cbox.cy * 14, SColorText());
int i = 0;
int my = cs.y + 1;
w.DrawRect(cs.x, cs.y + 14 * cbox.cy, cbox.cx * 18 + 1, 1, SColorText());
Point pp = Null;
for(int y = 0; y < 14; y++) {
w.DrawRect(cs.x, my - 1, cbox.cx * 18 + 1, 1, SColorText());
int mx = cs.x + 1;
for(int x = 0; x < 18; x++) {
Color c = GetColor(i++);
w.DrawRect(mx, my, cbox.cx - 1, cbox.cy - 1, c);
if(c == color)
pp = Point(mx, my);
mx += cbox.cx;
}
my += cbox.cy;
}
if(!IsNull(pp)) {
Size isz = CtrlImg::wheel_cursor().GetSize();
pp = pp + (cbox - isz) / 2;
w.DrawImage(pp.x, pp.y, CtrlImg::wheel_cursor(),
Grayscale(color) < 120 ? White() : Black());
}
}
</pre></p> Feature #1958 (Approved): IconDes should allow to specific color via SetColor functionalityhttps://www.ultimatepp.org/redmine/issues/19582019-04-30T21:18:27ZZbigniew Rebacz
<p>SetColor functionality is nice tool available in color selector pop up. It should be also avialble in IconDes to specific color with value. For example if I have HTML color code I can paste "#B68800" and the color should be selected automatically.</p> Feature #1957 (Approved): Export PNG's inside IconDesigner should support varianthttps://www.ultimatepp.org/redmine/issues/19572019-04-28T10:54:58ZZbigniew Rebacz
<p>Now when we have two icons (normal and dark) only the last one from the browser is exported. We should add to file name the flag name as well. For example the icon is header when it is in dark mode variant it should be exported to header_dk.png.</p> Bug #1272 (Approved): New icon should have selected "Standard" resolutionhttps://www.ultimatepp.org/redmine/issues/12722015-09-16T18:45:31ZZbigniew Rebacz
<p>Moreover fix new ide icons such as EditText, EditHex etc.</p> Bug #1271 (Approved): Wrong title in edit image dialoghttps://www.ultimatepp.org/redmine/issues/12712015-09-16T18:09:39ZZbigniew Rebacz
<p>When user wants to edit image in IconDes the window that pop-ups have title "New image". We need to change it to "Edit image".</p>
<p>Patch in diff allows to specific title by context. So insert image dlg titling works as previous.</p> Bug #979 (Approved): IconDes totally stops working after moving the splitter on toolbarhttps://www.ultimatepp.org/redmine/issues/9792015-02-07T17:53:24ZZbigniew Rebacz
<p>It seems that in IconDes splitter position can be moved on the toolbar. After that edition is impossible (even after restart).</p> Bug #965 (Approved): IconDes - Text tool stop workinghttps://www.ultimatepp.org/redmine/issues/9652015-01-21T22:06:14ZZbigniew Rebacz
<p>It seems that something causes text tool to stop working. This error is simply, text cannot be display for Normal/Bold/Italic option. It is always set to <abbr title="Color, 0">RGBA</abbr>. For Strikeout it works (Strange!).</p> Bug #674 (Approved): IconDes "Export Pngs" dosen't respect cancel buttonhttps://www.ultimatepp.org/redmine/issues/6742014-01-31T20:58:50ZZbigniew Rebacz
<p>It seems that "Export Pngs" dosen't respect cancel button. It is funny when you cancel operation and yours home directory is full of pngs files :). I enclose patched source file(Pure version). But I would like to explain what I changed with commentary(IconDes::ExportPngs() - line 199):<br /><pre>
<code class="cpp syntaxhl"><span class="CodeRay"><span class="directive">void</span> IconDes::ExportPngs()
{
String dir = SelectDirectory();
<span class="keyword">if</span>(!dir.IsEmpty()) <span class="comment">// <- Additional check</span>
<span class="keyword">for</span>(<span class="predefined-type">int</span> i = <span class="integer">0</span>; i < GetCount(); i++)
PNGEncoder().SaveFile(AppendFileName(dir, GetName(i) + <span class="string"><span class="delimiter">"</span><span class="content">.png</span><span class="delimiter">"</span></span>), GetImage(i));
}
</span></code><br /></pre></p>
<p>BTW, It is possible to export one certain icon instead of all in IconDes.</p> Feature #595 (Approved): Missing smoothen icon in IconDeshttps://www.ultimatepp.org/redmine/issues/5952013-12-02T17:12:14ZZbigniew Rebacz
<p>I think, we should improve several IconDes icons by using smoothen filter.</p>
<p>P.S<br />I used two base values (0.6 & 0.75) for smoothen algorithm.</p>