Feature #1990

ide/LayDes: Line endings support for layout designer

Added by Sender Ghost 9 months ago. Updated 9 months ago.

Status:ApprovedStart date:10/06/2019
Priority:NormalDue date:
Assignee:Sender Ghost% Done:

0%

Category:IDESpent time:-
Target version:-

Description

As you may know, if the layout (*.lay) file has other than "\r\n" line endings, they maybe converted to "\r\n", if open (and close or switch to a different file, if "Save file on TheIde window deactivation" is not enabled for Editor settings) mentioned file in TheIDE's layout designer (for example, at 13628 revision). As a consequence, this may affect creation of patches for layout file(s), which may include changes for line endings, among other things. There was a need to convert affected layout file(s) to previous line endings state to fix this.

Some examples of LF ("\n") layout files:
uppsrc/CodeEditor/CodeEditor.lay
uppsrc/CtrlLib/Ctrl.lay
uppsrc/IconDes/IconDes.lay
uppsrc/ide/ide.lay
uppsrc/ide/LayDes/LayDes.lay

Some examples of CRLF ("\r\n") layout files:
uppsrc/Docking/Docking.lay
uppsrc/ide/MacroManager/MacroManager.lay
uppsrc/ScatterCtrl/ScatterCtrl.lay
uppsrc/urepo/urepo.lay
uppsrc/urepo/usvn.lay

I propose to detect known line endings for TheIDE's layout designer, which are used to save the layout to a file.

uppsrc_ide_LayDes.diff Magnifier - Proposed patch for uppsrc/ide/LayDes files (since 13628 revision) (3.16 KB) Sender Ghost, 10/07/2019 04:10 AM

History

#1 Updated by Sender Ghost 9 months ago

  • File deleted (uppsrc_ide_LayDes.diff)

#2 Updated by Sender Ghost 9 months ago

  • File uppsrc_ide_LayDes.diff added

#3 Updated by Sender Ghost 9 months ago

  • File deleted (uppsrc_ide_LayDes.diff)

#4 Updated by Sender Ghost 9 months ago

  • File uppsrc_ide_LayDes.diff added

#5 Updated by Sender Ghost 9 months ago

  • File deleted (uppsrc_ide_LayDes.diff)

#6 Updated by Sender Ghost 9 months ago

  • File uppsrc_ide_LayDes.diff added

#7 Updated by Sender Ghost 9 months ago

  • File deleted (uppsrc_ide_LayDes.diff)

#8 Updated by Sender Ghost 9 months ago

  • File uppsrc_ide_LayDes.diff added

#9 Updated by Sender Ghost 9 months ago

  • File deleted (uppsrc_ide_LayDes.diff)

#10 Updated by Sender Ghost 9 months ago

Moved EOL to LayDes class as static variable.

#11 Updated by Sender Ghost 9 months ago

  • Status changed from New to Patch ready

#12 Updated by Sender Ghost 9 months ago

I also attached merged patch in #1992 issue.

#13 Updated by Sender Ghost 9 months ago

  • Status changed from Patch ready to Approved
  • Assignee changed from Miroslav Fidler to Sender Ghost

Improved changes was committed at 13635 revision.

Also available in: Atom PDF