Bug #1995

Draw: The xcb library dependency is not required for uppsrc/Draw package on FreeBSD

Added by Sender Ghost over 4 years ago. Updated over 4 years ago.

Status:RejectedStart date:10/16/2019
Priority:NormalDue date:
Assignee:Miroslav Fidler% Done:

0%

Category:DrawSpent time:-
Target version:-

Description

The xcb library dependency was added for uppsrc/Draw package at 1254 svn revision. But xcb library dependency wasn't removed after 1436 svn revision when 'library(BSD) "X11 Xau Xdmcp";' line was removed from uppsrc/Draw/Draw.upp file. The Xau and Xdmcp are library dependencies for xcb library:

% ldd -a /usr/local/lib/libxcb.so | sed -e 's/ (.*)$//'
/usr/local/lib/libxcb.so:
    libXau.so.6 => /usr/local/lib/libXau.so.6
    libXdmcp.so.6 => /usr/local/lib/libXdmcp.so.6
    libthr.so.3 => /lib/libthr.so.3
    libc.so.7 => /lib/libc.so.7
/usr/local/lib/libXau.so.6:
    libc.so.7 => /lib/libc.so.7
/usr/local/lib/libXdmcp.so.6:
    libc.so.7 => /lib/libc.so.7
/lib/libthr.so.3:
    libc.so.7 => /lib/libc.so.7

The examples/AddressBook and reference/ConsoleDraw packages builds ok on FreeBSD, if remove "library(FREEBSD) xcb;" line from uppsrc/Draw/Draw.upp file.

For example, (filtered) ldd output for ConsoleDraw executable:

% ldd -a ./ConsoleDraw | sed 's/ (.*)$// ; s|^/.*/||' | head -15
ConsoleDraw:
    libfontconfig.so.1 => /usr/local/lib/libfontconfig.so.1
    libfreetype.so.6 => /usr/local/lib/libfreetype.so.6
    libexpat.so.1 => /usr/local/lib/libexpat.so.1
    libpng16.so.16 => /usr/local/lib/libpng16.so.16
    libthr.so.3 => /lib/libthr.so.3
    librt.so.1 => /usr/lib/librt.so.1
    libexecinfo.so.1 => /usr/lib/libexecinfo.so.1
    libz.so.6 => /lib/libz.so.6
    libc++.so.1 => /usr/lib/libc++.so.1
    libcxxrt.so.1 => /lib/libcxxrt.so.1
    libm.so.5 => /lib/libm.so.5
    libgcc_s.so.1 => /lib/libgcc_s.so.1
    libc.so.7 => /lib/libc.so.7
libfontconfig.so.1:

There is xcb library dependency in uppsrc/CtrlCore package for examples/AddressBook case.

Patch attached.

uppsrc_Draw.diff Magnifier - Proposed patch for uppsrc/Draw (since 13647 revision) (293 Bytes) Sender Ghost, 10/16/2019 09:17 PM

reference_ConsoleDraw.diff Magnifier - Proposed patch for reference/ConsoleDraw (since 13647 revision) (259 Bytes) Sender Ghost, 10/16/2019 09:41 PM

History

#1 Updated by Sender Ghost over 4 years ago

Also possible to remove duplicate PdfDraw package dependency for reference/ConsoleDraw package.

#2 Updated by Sender Ghost over 4 years ago

  • Status changed from New to Patch ready
  • Assignee set to Miroslav Fidler

#3 Updated by Sender Ghost over 4 years ago

The expat library dependency also probably not required for uppsrc/Draw package, but this may need testing for other platforms.

#4 Updated by Sender Ghost over 4 years ago

  • Description updated (diff)

#5 Updated by Sender Ghost over 4 years ago

  • Status changed from Patch ready to Rejected

This issue was rejected/closed, because of changes in 13917 svn revision, related to pkg-config usage for xcb case.
The patch for reference/ConsoleDraw is still valid, but optional. Also reference/ConsoleDraw package builds ok without xcb (and x11) on FreeBSD, but maybe there is another use case for it (them).

Also available in: Atom PDF