Bug #228

FileSel bug in 4354

Added by Jan Dolinár over 7 years ago. Updated over 7 years ago.

Status:ApprovedStart date:12/30/2011
Priority:UrgentDue date:
Assignee:Tomas Rylek% Done:

100%

Category:GeneralSpent time:-
Target version:-

Description

The revision 4354 contains error preventing the compilation of CtrlLib/FileSel.cpp, at least with GCC:

uppsrc/CtrlLib/FileSel.cpp:1358:7: error: name lookup of ‘i’ changed for ISO ‘for’ scoping [-fpermissive]

Fix is simple, please apply:

Index: uppsrc/CtrlLib/FileSel.cpp
===================================================================
--- uppsrc/CtrlLib/FileSel.cpp    (revision 4354)
+++ uppsrc/CtrlLib/FileSel.cpp    (working copy)
@@ -1355,7 +1355,7 @@
             dir <<= GetHomeDirectory();
         if(lru.GetCount())
             dir.AddSeparator();
-        for(i = 0; i < lru.GetCount(); i++)
+        for(int i = 0; i < lru.GetCount(); i++)
             if(IsFullPath(lru[i]) && filesystem->FolderExists(lru[i]))
                 dir.Add(lru[i]);
         dir.SetDisplay(Single<FolderDisplay>(), max(16, Draw::GetStdFontCy()));

History

#1 Updated by Jan Dolinár over 7 years ago

  • Status changed from Patch ready to Approved
  • % Done changed from 0 to 100

Also available in: Atom PDF