Task #279

Core/Value.hpp:177:9: warning: unused variable ‘t’

Added by Massimo Del Fedele over 7 years ago. Updated over 7 years ago.

Status:ApprovedStart date:04/28/2012
Priority:ImmediateDue date:
Assignee:Massimo Del Fedele% Done:

100%

Category:CoreEstimated time:0.10 hour
Target version:-Spent time:-

Description

t variable is not used in optimal mode.
It should be surrounded by ifdef, otherwise tons of warnings when building.

History

#1 Updated by Miroslav Fidler over 7 years ago

  • Priority changed from Normal to Immediate

#2 Updated by Miroslav Fidler over 7 years ago

  • Assignee changed from Miroslav Fidler to Massimo Del Fedele

Weird:

template <class T>
void Value::SvoRegister(const char *name)
{
    dword t = GetValueTypeNo<T>();
    ASSERT(t < 255);
    SVO_FN(sval, T)
    svo[t] = &sval;
    AddName(t, name);
}

I would swear it is used in optimal mode too?!

#3 Updated by Miroslav Fidler over 7 years ago

  • Status changed from New to Ready for QA

Sry, wrong line. Fixed.

#4 Updated by Massimo Del Fedele over 7 years ago

  • Status changed from Ready for QA to In Progress
  • Assignee changed from Massimo Del Fedele to Miroslav Fidler

Sorry, at least here :

template <class T>
T& Value::GetSmall() const
{
    dword t = GetValueTypeNo<T>();
    ASSERT(t < 255 && (t == STRING_V ? IsString() : Is((byte)t)));
    return *(T*)&data;
}

the problem is still present.
I recompiled it with an #ifdef and there are no warnings anymore.

#5 Updated by Miroslav Fidler over 7 years ago

  • Status changed from In Progress to Ready for QA
  • Assignee changed from Miroslav Fidler to Massimo Del Fedele

And now?

#6 Updated by Massimo Del Fedele over 7 years ago

  • Status changed from Ready for QA to Approved
  • % Done changed from 0 to 100

It's ok now.

Btw, I don't get any mail from redmine.... I keep missing your updates.

Max

Also available in: Atom PDF