Bug #488

Broken plugin/zip

Added by Jan Dolinár almost 12 years ago. Updated almost 12 years ago.

Status:ApprovedStart date:06/30/2013
Priority:NormalDue date:
Assignee:Miroslav Fidler% Done:

100%

Category:GeneralSpent time:-
Target version:-

Description

I tried using plugin/zip for a while and noticed some of the functionality is seriously broken, both with GCC 4.8.1 and Clang 3.3. Two simple test cases:

    StringStream out;
    Zip zip(out); // fails here

    StringZip szip;
    szip.WriteFile("test","test.txt"); // fails here

The first one crashes the program due to uninitialized variables, so it might be caused by my compiler settings, but I think it should be fixed anyway. The second one is definitely an error in code of StringZip::Create(). Patch is attached...

zip.patch Magnifier (772 Bytes) Jan Dolinár, 06/30/2013 09:20 PM

History

#1 Updated by Jan Dolinár almost 12 years ago

  • File zip.patchMagnifier added
  • Subject changed from Broken to Broken plugin/zip

#2 Updated by Miroslav Fidler almost 12 years ago

  • Status changed from Patch ready to Approved

Also available in: Atom PDF