U++ forum: Welcome to the forum

Re: Upp 2008.1beta2 v2 released [message #15173 is a reply to message #15015]

Mon, 07 April 2008 12:28

mr_ped
Messages: 826
Registered: November 2005
Location: Czech Republic - Praha

Experienced Contributor

I'm trying all examples with beta2, and OleCalc is giving me some compilation problems, I will have to dig deeper into them to understand what's going on, but so far I found some disturbing things in other packages as well.

C:\upp\uppsrc\Core\Dli.cpp(138) : warning C4390: ';' : empty controlled statement found; is this the intent?

				if(!missing)
					LLOG(fn << " missing exports:");

I suggest to enclose the LLOG into {} to make sure the "if" will work even when LLOG consists of thing like "Function1(); Function2()".

c:\upp\uppsrc\core\lang.cpp(1088) : warning C4715: 'Upp::GetLanguageInfo' : not all control paths return a value

	LanguageInfo *rinfo = 0;   //line 1072

Shouldn't this be static? Doesn't make sense to me in current version.
And as far as I can tell calling this with lcode != 0 will reach the end of function without "return" statement.

Digging more into OleCalc itself:

The calc_idl.cpp has pending UVS conflict! Very Happy

Under MINGW I get:
C:\upp\uppsrc/Ole/Ctrl/OleCtrl.h:141: error: 'Guid' was not declared in this scope
This is due to uppsrc/Ole/util.h starting with

#if defined(PLATFORM_WIN32) && defined(COMPILER_MSC)

so the Guid class is not defined at all under MINGW.

Should be this "Ole" package compiled only under MSVC? If so, can we add some WHEN MSC into build, so it will not compile under MINGW at all, and into OleCalc/calc.cpp some

#if !defined(COMPILER_MSC)
#error "This example is for MSC only!"
#endif

So anyone trying this with MINGW will get only single error message?

[Updated on: Tue, 08 April 2008 14:15]

Report message to a moderator