U++ forum: Welcome to the forum

Re: Raster Control [message #15204 is a reply to message #15198]

Wed, 09 April 2008 10:28

mdelfede
Messages: 1310
Registered: September 2007

Ultimate Contributor

mr_ped wrote on Tue, 08 April 2008 17:34

I'm trying it from 2008.1beta2 installation, and I hit crash right after opening first image I found on my disc. Smile

well, 2008.1beta2 has an outdated version, anyways... bugs pointed out by mrjt (which caused crash on MSC) are corrected in svn. Please try it, just pick Bazaar from svn, if you don't like to work with upp-svn package.
BTW I stopped upgrading svn packages for the moment cause some lettercase mismatches in uvs2 that brings some problems in linux.

Quote:

It turned out the very first image I found was gif, and you didn't add plugin/gif package, so the RasterCtrl\RasterCtrl.cpp:55 line

raster = StreamRaster::OpenAny(imageStream);

ends with NULL assigned to raster.

Than the next for loop

	for(curPage = 0; curPage < raster->GetPageCount(); curPage++)

will crash due to referencing null pointer.

I think there should be some error handler instead of crash in case the input stream did not result into valid raster object.

I agree with you, the package isn't yet refined, in particular to error handling. I'll add some error checks soon.... sorry for the inconvenience but I made the package for a particular need, not yet with production quality in mind Smile

About the gif plugin, I'm not sure if I should add it to RasterControl package or leave it to users if they need it... But that apply to tiff too. IMHO would be better to leave grafic formats out of rastercontrol package and let users include just what they need.

Quote:

Another funny thing I encountered was opening that gif finally (after I did add plugin/gif package), it fits the width of window (it's scaled up a bit) with vertical scrollbar, than I used View / Zoom 10%, than View / Page width, and I do get both vertical and horizontal scrollbars suddenly. After using View / Page width second time, the horizontal scrollbars is gone and I have the "default" view just like after opening the image.

uh ? I didn't notice that behaviour.... it should hide scrollbars when not needed. A known problem is that it can loose the space used by scrollbars (it makes it necessary to calculate the sizes both for control with and without scrollbars to solve it, it's planned but I'm looking for a good (and quick) solution.
But scrollbars hiding should work... can you post a sample image ?

Finally, I'm now working to the hard(ware) part of my fax application, the modem/serial port/threads stuffs, which is quite complicated. When it'll ok, I'll join together with RasterControl so I'll test it much more in depth....

Max

Report message to a moderator