U++ forum: Welcome to the forum

Re: DirectoryUp doesn't seem to work. [message #18573 is a reply to message #18554]

Thu, 09 October 2008 16:11

mr_ped
Messages: 826
Registered: November 2005
Location: Czech Republic - Praha

Experienced Contributor

I'm sorry, but I'm unable to work on this right now, but I want to get back to it next week, and rewrite it from scratch.

But Mjrt has valid point about how it works right now, but I think the trailing slash should be handled as well.

Quote:

ASSERT(DirectoryUp("/home/Isaac/") == "/home");
ASSERT(DirectoryUp("/home/Isaac") == "/home");

No, the directory is changed as reference variable.
The return value of function is the name of directory which was left, i.e. in both cases the return value should be "Isaac", the only question is whether it should return Isaac/ and Isaac, or just Isaac.

Whichever you prefer, write here, I can't decide myself, but I think erasing the trailing slash always will in the end make it easier to use, even if you would have to add slash back in special cases.

Mjrt: I mostly don't like the code itself, there's way too much #ifdef and code duplicity for my taste. I have already some idea how to write it much more cleanly, but I don't have time right now. :/

Report message to a moderator