U++ forum: Welcome to the forum

Re: Problem and fix in LocalProcess [message #28560 is a reply to message #28558]

Tue, 07 September 2010 08:42

koldo
Messages: 3443
Registered: August 2008

Senior Veteran

luzr wrote on Tue, 07 September 2010 05:33

koldo wrote on Mon, 06 September 2010 11:44

Hello Mirek

Now LocalProcess::Read(String& res) function in Windows includes this in LocalProcess.cpp line 341:

	res.Cat(buffer, n);

It should be replaced with this:

	res.Cat(FromSystemCharset(buffer), n);

This way accents and other chars are not lost.

Should not it rather be

res = FromSystemCharset(String(buffer, n)))

?!

Frankly, we are perhaps missing FromSystemCharser(const char *, int count) variant here, I guess...

Hello Mirek

For me Cat was good but really you have a finer grain view.

However you are right. It seems FromSystemCharser(const char *, int count) would be the best option.

Best regards
Iñaki

Report message to a moderator