U++ forum: Welcome to the forum

Search on this site

Search in forums

Home » U++ Library support » U++ Core » To get xml errors from LoadFromXML

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

To get xml errors from LoadFromXML [message #37806]

Wed, 14 November 2012 09:18

koldo
Messages: 3432
Registered: August 2008

Senior Veteran

Hello all

Now it is not possible to get errors in XML strings detected by LoadFromXML() because they are catched inside and removed.

I would vote to remove the try-catch from LoadFromXML() and let the programmer to handle the error properly.

bool LoadFromXML(Callback1<XmlIO> xmlize, const String& xml)
{
	try {
		XmlNode node = ParseXML(xml);
		if(node.GetCount() == 0)
			return false;
		for(int i = 0; i < node.GetCount(); i++)
			if(node.Node(i).IsTag()) {
				Value dummy;
				xmlize(XmlIO(node.At(i), true, dummy));
				break;
			}
		return true;
	}
	catch(XmlError) {}    // XmlError is removed
	return false;
}

Best regards
Iñaki

Report message to a moderator

Re: To get xml errors from LoadFromXML [message #37901 is a reply to message #37806]

Wed, 21 November 2012 11:26

crydev
Messages: 151
Registered: October 2012
Location: Netherlands

Experienced Member

I agree with this. I am using this code as container for my application settings and when I alter my XML file to be wrong and start my application after, the application crashes after it reaches 2 GB memory usage. I would really like to catch the error that currently is suppressed there.

Report message to a moderator

Re: To get xml errors from LoadFromXML [message #37913 is a reply to message #37901]

Thu, 22 November 2012 22:45

crydev
Messages: 151
Registered: October 2012
Location: Netherlands

Experienced Member

I have found a temporary solution for this problem, would anybody need it:

bool LoadFromXML(Callback1<XmlIO> xmlize, const String& xml)
{
	try {
		XmlNode node = ParseXML(xml);
		if(node.GetCount() == 0)
			return false;
		for(int i = 0; i < node.GetCount(); i++)
			if(node.Node(i).IsTag()) {
				Value dummy;
				xmlize(XmlIO(node.At(i), true, dummy));
				break;
			}
		return true;
	}
	catch(XmlError x)
        {
            throw x;
        }    // XmlError is removed
	return false;
}

Now just use try-catch in your LoadFromXML call to handle the thrown error.

This works for now, and since most situations XML operations won't be performance critical this solution isn't a too bad one. However, in my opinion this should be fixed.

Report message to a moderator

Re: To get xml errors from LoadFromXML [message #42107 is a reply to message #37913]

Thu, 20 February 2014 08:53

mirek
Messages: 14256
Registered: November 2005

Ultimate Member

Only for reference purposes, if anybody finds this thread again, use

TryLoadFromXML

Mirek

Report message to a moderator

Previous Topic:	Xmlize default value
Next Topic:	Bug: AString<B>::ReverseFind broken for wchar

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Wed Apr 30 13:22:36 CEST 2025

Total time taken to generate the page: 0.04796 seconds