U++ forum: Welcome to the forum

Hi,

i im trying to use NTLM authentication with HttpRequest,

for NTLM, i note the following particularity:
- Use 3 "GET" request.
- Keep connection alive between at least the lasts tow request.
- Use DES encryption.

After analysis of the used authentication mechanism in HttpRequest, I propose the following patch:

1 - remove the member variable "force_diget" et "digest"
2 - add a new memerer variable String "autheticate_header"
3 - in the void HttpRequest::StartRequest(), replace :

	if(!IsNull(digest))
		data << "Authorization: Digest " << digest << "\r\n";
	else
	if(!force_digest && (!IsNull(username) || !IsNull(password)))
		data << "Authorization: Basic " << Base64Encode(username + ":" + password) << "\r\n";

	data << autheticate_header;

4 - change 401 error management, in void HttpRequest::Finish(), replace :

	if(status_code == 401 && !IsNull(username)) {
		String authenticate = header["www-authenticate"];
		if(authenticate.GetCount() && redirect_count++ < max_redirects) {
			LLOG("HTTP auth digest");
			Digest(CalculateDigest(authenticate));
			Start();
			return;
		}
	}

	if(status_code == 401) {
		
		String authenticate = header["www-authenticate"];
		if(authenticate.GetCount() && redirect_count++ < max_redirects) {
			if(!IsNull(username) || !IsNull(password)) {
			
				if(authenticate.StartsWith("Basic"))
				{
					autheticate_header = "Authorization: Basic " + Base64Encode(username + ":" + password)+ "\r\n";
				}
				else
				if(authenticate.StartsWith("Digest"))
				{
					LLOG("HTTP auth digest");
					autheticate_header = "Authorization: Digest " + CalculateDigest(authenticate) + "\r\n";
				}
				else
				{
					WhenAuthentication(*this);
				}
			}
			else {
				WhenAuthentication(*this);
			}
			
			if(keep_alive)
				StartRequest();
			else
				Start();

			return;
		}
	}

5 - WhenAuthentication is declared as:

	Callback1<HttpRequest&>		WhenAuthentication;

6 - Add a mehode void ForceBasic(String user, String pw)

	void ForceBasic(String user, String pw) {autheticate_header << "Authorization: Basic " << Base64Encode(user + ":" + pw) << "\r\n";}

with this patch, a custom Authentication function can be added :

void Autenticate(HttpRequest& http)
{
	String www_authenticate = http.GetHeader("www-authenticate");
	if(!www_authenticate.StartsWith("NTLM"))
	{
		return;
	}
	//...
}
...
HttpReqest r;
r.WhenAuthentication = callback(Autenticate);