U++ forum: Welcome to the forum

[BUG] Removed properties of CommonFontInfo struct are referenced in XFtGetFontInfoSys() [message #50408]

Fri, 19 October 2018 10:47

Oblivion
Messages: 1254
Registered: August 2007

Senior Contributor

Hello,
As I reported here https://github.com/ultimatepp/mirror/issues/4 ,

Below properties (height, lineheight) seem to be removed from CommonFontInfo some time ago.
Yet they are still used in XFtGetFontInfoSys() function. This leads to a compiler error when the NOGTK mode is enabled.

mirror/uppsrc/CtrlCore/DrawTextX11.cpp
Lines 118 to 119 in cf97a1a

fi.height = fi.ascent + fi.descent; 
fi.lineheight = (int16)xftfont->height;

Best regards,
Oblivion

Github page: https://github.com/ismail-yilmaz
Bobcat the terminal emulator: https://github.com/ismail-yilmaz/Bobcat

Report message to a moderator