Home » Developing U++ » UppHub » AutoScroller package update
| AutoScroller package update [message #55187] |
Fri, 16 October 2020 10:51  |
warchef
Messages: 13
Registered: January 2019
Location: Hungary
|
Promising Member |
|
|
Hello,
i did a patch which eliminates compile error in this package (include error).
Sincerely,
warchef
|
|
|
|
| Re: AutoScroller package update [message #55188 is a reply to message #55187] |
Fri, 16 October 2020 11:04  |
 |
Klugier
Messages: 1099
Registered: September 2012
Location: Poland, Kraków
|
Senior Contributor |
|
|
Hello Warchef,
Could you check latest nightly version. Some time ago I pushed similar changes into trunk. I am also glad you post your solution to the problem here. It means a lot in context of U++ development. Thanks!
Klugier
U++ - one framework to rule them all.
[Updated on: Fri, 16 October 2020 11:05] Report message to a moderator |
|
|
|
|
|
|
|
| Re: AutoScroller package update [message #56323 is a reply to message #56301] |
Sun, 21 February 2021 01:49 |
|
Klugier
Messages: 1099
Registered: September 2012
Location: Poland, Kraków
|
Senior Contributor |
|
|
Hello Dider,
I created AutoScroller UppHub package that basses on the bazzar implementation. It should be available when my PR will be accepted.
Als I added some improvements to the implementation:
- AutoScroller is no longer template class it inherits from ParentCtrl directly. This is breaking API change, but it is good time to do it.
- Added Layout designer integration. You could directly place AutoScroller in the layout (under Special controls category)
- Layout under AutoScroller can be scrolled with mouse wheel
- Fixed problem with scrolling, now the scrolling resolution is set correctly.
- Some code cleanup
Please test when package will be available on UppHub and let me know what is your opinion.
Klugier
U++ - one framework to rule them all.
[Updated on: Sun, 21 February 2021 01:50] Report message to a moderator |
|
|
|
| Re: AutoScroller package update [message #56324 is a reply to message #56323] |
Sun, 21 February 2021 11:33 |
Oblivion
Messages: 1212
Registered: August 2007
|
Senior Contributor |
|
|
Hello Klugier,
Quote:Please test when package will be available on UppHub and let me know what is your opinion.
It works very well, thanks to you and Kohalt00.
Since it is time you've already slightly broken the API, is it possible and feasible to rename it to AutoScrollerCtrl and keep the old name as an alias with a warning that the alias will be removed with upp 2021.2 (as I did in TerminalCtrl)?
This suggestion is to keep consistency but it it of course up to you and its users.
Best regards,
Oblivion
Github page: https://github.com/ismail-yilmaz
Bobcat the terminal emulator: https://github.com/ismail-yilmaz/Bobcat
[Updated on: Sun, 21 February 2021 11:37] Report message to a moderator |
|
|
|
| Re: AutoScroller package update [message #56329 is a reply to message #56323] |
Sun, 21 February 2021 19:47 |
Didier
Messages: 728
Registered: November 2008
Location: France
|
Contributor |
|
|
Hello Klugier,
Thank you 
Well a github package is OK but since this is kind of basic functionnality which many can need, I think it should rather be directly in Uppsrc
Thank's for the layout file (I would have done one anyway and I might contribute a more complex drawing : draw the scrolling cursors)
I will try you're version quickly
[Updated on: Sun, 21 February 2021 19:51] Report message to a moderator |
|
|
|
|
|
| Re: AutoScroller package update [message #56465 is a reply to message #56330] |
Sat, 13 March 2021 23:08 |
Didier
Messages: 728
Registered: November 2008
Location: France
|
Contributor |
|
|
Hello Klugier,
I took 10 minutes to enhance .usc file.
Following code adds drawing of sidebars
Quote: Paint(w) {
r = GetRect();
sbWidth = 16;
sr = r;
sr.right = sr.right-sbWidth;
sr.bottom = sr.bottom-sbWidth;
vsb = sr;
vsb.left = sr.right;
vsb.right = r.right;
hsb = sr;
hsb.top = sr.bottom;
hsb.bottom = r.bottom;
PaintHScrollBar(w, hsb);
PaintVScrollBar(w, vsb);
DrawCtrlFrame(w, r, .SetFrame);
DrawBorder(w, r, :SGray, :SGray);
sr.right = sr.right-sbWidth; ___________ // normaly shoudn't need this, but still had to add it otherwise ClassName overlaps VScrollbar ???
DrawClassName(w, sr, "AutoScroller");
}
[Updated on: Sat, 13 March 2021 23:11] Report message to a moderator |
|
|
|
|
|
|
|
Goto Forum:
Current Time: Tue Jun 17 04:51:01 CEST 2025
Total time taken to generate the page: 0.06619 seconds
|
Members
Pages
Help
Register
Login
Home
Cool. Thanks for porting and fixing in all the years.
