Another issue... On Linux Mint and UHD 4k display the console output (when compiling) is using a very tiny little font... And even if I zoom it in using Ctrl+Wheel, on next startup of TheIDE it has shrinked again back. All other panels in TheIDE seem to follow the UHD sizing.

// Tom

Tom1 wrote on Thu, 12 September 2024 11:48

Another issue... On Linux Mint and UHD 4k display the console output (when compiling) is using a very tiny little font... And even if I zoom it in using Ctrl+Wheel, on next startup of TheIDE it has shrinked again back. All other panels in TheIDE seem to follow the UHD sizing.

// Tom

What is in Setup/Settings? (Maybe screenshot...)

Also, TheIDE font sizes are set once on the very first start. Perhaps you started in HD and only later switched to UHD ?

Nightly build is stopped.

it seams that the builder host need update in order to use C++17

Thanks.

mirek wrote on Fri, 13 September 2024 20:42

Tom1 wrote on Thu, 12 September 2024 11:48

Another issue... On Linux Mint and UHD 4k display the console output (when compiling) is using a very tiny little font... And even if I zoom it in using Ctrl+Wheel, on next startup of TheIDE it has shrinked again back. All other panels in TheIDE seem to follow the UHD sizing.

// Tom

What is in Setup/Settings? (Maybe screenshot...)

Also, TheIDE font sizes are set once on the very first start. Perhaps you started in HD and only later switched to UHD ?

It's entirely possible that it was mixed up on the very first start. Cannot check right now as the issue surfaced at the office. My home installation seems to work just fine. Also, I did not know that changing console font by Ctrl+Wheel is not persistent. (In the code editor it seems to be.)

I guess this can be considered solved. I will let you know next week if this is not the case once I check my office setup.

Thanks and best regards,

Tom

First I tried to fix it by using 'Restore defaults' and then 'Close'. This caused TheIDE to crash on every attempt. Then I selected the same font sizes manually and the values were successfully updated after close. So, there must be some issue with 'Restore defaults'.
Tom

Tom1 wrote on Mon, 16 September 2024 10:21

First I tried to fix it by using 'Restore defaults' and then 'Close'. This caused TheIDE to crash on every attempt. Then I selected the same font sizes manually and the values were successfully updated after close. So, there must be some issue with 'Restore defaults'.
Tom

Should be now fixed.

Thank you mirek for all the hard work!

I have a question. In CoWork.h, line 186, etc,

		void Do(Function&& f, Args&&... args) { co.Do([=]() { ret = f(args...); }); }

shouldn't it be something like

void Do(Function&& f, Args&&... args) { co.Do([=]() { ret = f(std::forward<Args>(args)...); }); }

for perfect forwarding to actually work?

#include <Core/Core.h>

using namespace Upp;

CONSOLE_APP_MAIN
{
	auto a = Async([](int n) -> double {
		double f = 1;
		for(int i = 2; i <= n; i++)
			f *= i;
		return f;
	}, 100);
}

The current upp codebase works fine with std=c++20, except the warning: implicit capture of 'this' with a capture default of '=' is deprecated [-Wdeprecated-this-capture] issue. This can be fixed without much effort and without affecting the aimed standard of c++17. I was wondering if you would consider accepting it if I make a pull request for that.

Thank you mirek for all the hard work!

I have a question. In CoWork.h, line 186, etc,

		void Do(Function&& f, Args&&... args) { co.Do([=]() { ret = f(args...); }); }

shouldn't it be something like

void Do(Function&& f, Args&&... args) { co.Do([=]() { ret = f(std::forward<Args>(args)...); }); }

for perfect forwarding to actually work?

Lance wrote on Tue, 17 September 2024 17:34

The current upp codebase works fine with std=c++20, except the warning: implicit capture of 'this' with a capture default of '=' is deprecated [-Wdeprecated-this-capture] issue. This can be fixed without much effort and without affecting the aimed standard of c++17. I was wondering if you would consider accepting it if I make a pull request for that.

Nope, cannot do that with C++17. Requires [=, this], which is C++20 feature. And, frankly, while [=] capturing 'this' is perhaps confusing, everybody is used to it by now so to require longer code for the same thing is at this point is kind of pointless... But when we go C++20, we shall do it anyway. In 3 years...

c++23 however will break many String interfaces.

/home/lance/upp.src/uppsrc/Core/String.h (556): error: non-const lvalue reference to type 'String' cannot bind to a temporary of type 'String'

force_inline String& operator<<(String&& s, const char *x)
{
	s.Cat(x, strlen__(x));
	return s;
}

with clang
when compiler flags set to -std=c++23 -Wno-logical-op-parentheses

we have multiple errors with messages like
Quote:

/home/lance/upp.src/uppsrc/Core/String.h (556): error: non-const lvalue reference to type 'String' cannot bind to a temporary of type 'String'

And the relevant source is

force_inline String& operator<<(String&& s, const char *x)
{
	s.Cat(x, strlen__(x));
	return s;
}

Now c++23 is rejecting code like these.

/home/lance/upp.src/uppsrc/Core/Stream.cpp (1226): error: no viable conversion from returned value of type 'StringBuffer' to function return type 'String'

String LoadFile(const char *filename) {
	FindFile ff(filename);
	if(ff && ff.IsFile()) {
	#ifdef PLATFORM_POSIX
		if(ff.GetLength() == 0) { // handle special cases like /proc/...
			int fd = open(filename,O_RDONLY);
			if(fd >= 0) {
				const int CHUNK = 32768;
				StringBuffer s;
				for(;;) {
					int n = s.GetCount();
					s.SetCount(n + CHUNK);
					int len = read(fd, ~s + n, CHUNK);
					if(len != CHUNK) {
						if(len >= 0)
							s.SetCount(n + len);
						close(fd);
						return s;   <---This Line

Hi Mirek,

Would it be possible to clean up these annoying warnings?

uppsrc/RichText/ParaPaint.cpp (468): warning: unused variable 'pe' [-Wunused-variable]
uppsrc/ide/IconDes/Event.cpp (102): warning: unused variable 'c' [-Wunused-variable]
uppsrc/ide/IconDes/IconDes.cpp (130): warning: unused variable 'isz' [-Wunused-variable]
uppsrc/ide/IconDes/ImlFile.cpp (272): warning: unused function 'PutOctalString' [-Wunused-function]
uppsrc/ide/SelectPkg.cpp:661:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
  661 |                 for(int i = 0; i < dlg.list.GetCount(); i++)
      |                 ^
uppsrc/ide/SelectPkg.cpp:658:2: note: previous statement is here
  658 |         if(n)
      |         ^
1 warning generated.

Thank you, Radek