Home » Community » U++ community news and announcements » DarkTheme function parameters changed
Re: DarkTheme function parameters changed [message #60826 is a reply to message #60824] |
Tue, 17 September 2024 20:31   |
Tom1
Messages: 1303 Registered: March 2007
|
Ultimate Contributor |
|
|
mirek wrote on Tue, 17 September 2024 18:00Tom1 wrote on Sat, 14 September 2024 22:32Now that DarkTheme() 'color inversion' works so great, maybe a slight tuning of default TheIDE text colors (along the lines laid out in material.io Dark theme documentation) is in place. I'm thinking about:
Default scheme should always be "host". However, I can add alternative dark theme, if you supply one. It is quite easy, check
CtrlLib/Ch.cpp:716
Mirek
I was actually just thinking about TheIDE accent colors for code editing and other views... just to adjust the dark variants to view nicely on dark backgrounds. But yes, this involves dark theme tuning as well to get contrast optimized.
I remember working on Win32 emulated dark theme colors. The trick was (and I think still is) that many definitions come from platform and mostly only colors need to be adjusted for the dark theme. I recall that the color changes had to be written in-line within ChHostSkin(). If I just create a function called e.g. ChMyCustomSkin(), similar to e.g. ChDarkSkin(), I will not get platform shapes/styles for widgets, but something else instead. Therefore, some reorganization would be helpful:
It would be nice to have theme loading clearly split to two parts:
1. Load system colors (custom or platform) and store with "SColor*_Write();" functions like before.
2. Load shapes/styles from host like in ChHostSkin() (or load custom shapes/styles), and combine with preloaded SColor*() colors for a complete theme.
Also live theme changes would be nice... We have talked about this before and at that time you warned about a potential problem that arises with some controls caching colors internally. Still, it would be an interesting improvement. (I can even imagine a generic Theme(Color)EditorDialog after live theme changes feature has been introduced...)
Best regards,
Tom
|
|
|
 |
|
DarkTheme function parameters changed
By: mirek on Tue, 10 September 2024 16:29
|
 |
|
Re: DarkTheme function parameters changed
By: Tom1 on Thu, 12 September 2024 12:03
|
 |
|
Re: DarkTheme function parameters changed
By: Tom1 on Thu, 12 September 2024 16:32
|
 |
|
Re: DarkTheme function parameters changed
By: mirek on Sat, 14 September 2024 16:31
|
 |
|
Re: DarkTheme function parameters changed
By: Tom1 on Sat, 14 September 2024 22:32
|
 |
|
Re: DarkTheme function parameters changed
By: mirek on Sun, 15 September 2024 10:10
|
 |
|
Re: DarkTheme function parameters changed
By: Tom1 on Mon, 16 September 2024 13:01
|
 |
|
Re: DarkTheme function parameters changed
By: mirek on Tue, 17 September 2024 09:10
|
 |
|
Re: DarkTheme function parameters changed
By: mirek on Tue, 17 September 2024 17:00
|
 |
|
Re: DarkTheme function parameters changed
By: Tom1 on Tue, 17 September 2024 20:31
|
 |
|
Re: DarkTheme function parameters changed
By: mirek on Tue, 17 September 2024 23:45
|
 |
|
Re: DarkTheme function parameters changed
By: Tom1 on Wed, 18 September 2024 21:11
|
 |
|
Re: DarkTheme function parameters changed
By: mirek on Wed, 18 September 2024 21:59
|
 |
|
Re: DarkTheme function parameters changed
By: Tom1 on Wed, 18 September 2024 22:37
|
 |
|
Re: DarkTheme function parameters changed
By: Lance on Sun, 06 October 2024 14:46
|
 |
|
Re: DarkTheme function parameters changed
By: mirek on Sun, 06 October 2024 21:35
|
 |
|
Re: DarkTheme function parameters changed
By: Lance on Sun, 06 October 2024 22:32
|
 |
|
Re: DarkTheme function parameters changed
By: mirek on Sun, 06 October 2024 21:37
|
 |
|
Re: DarkTheme function parameters changed
By: Lance on Sun, 06 October 2024 22:34
|
 |
|
Re: DarkTheme function parameters changed
By: Lance on Sun, 06 October 2024 22:52
|
 |
|
Re: DarkTheme function parameters changed
By: mirek on Mon, 07 October 2024 00:26
|
 |
|
Re: DarkTheme function parameters changed
By: Lance on Mon, 07 October 2024 01:59
|
 |
|
Re: DarkTheme function parameters changed
By: Tom1 on Mon, 07 October 2024 08:51
|
 |
|
Re: DarkTheme function parameters changed
By: mirek on Mon, 07 October 2024 09:40
|
 |
|
Re: DarkTheme function parameters changed
By: Tom1 on Mon, 07 October 2024 10:36
|
 |
|
Re: DarkTheme function parameters changed
By: Lance on Mon, 07 October 2024 14:03
|
 |
|
Re: DarkTheme function parameters changed
By: Tom1 on Mon, 07 October 2024 14:22
|
 |
|
Re: DarkTheme function parameters changed
By: mirek on Mon, 07 October 2024 09:43
|
 |
|
Re: DarkTheme function parameters changed
By: Lance on Mon, 07 October 2024 13:57
|
 |
|
Re: DarkTheme function parameters changed
By: mirek on Mon, 07 October 2024 14:48
|
 |
|
Re: DarkTheme function parameters changed
By: Lance on Mon, 07 October 2024 16:49
|
 |
|
Re: DarkTheme function parameters changed
By: Lance on Mon, 07 October 2024 17:24
|
 |
|
Re: DarkTheme function parameters changed
By: Lance on Mon, 07 October 2024 17:34
|
 |
|
Re: DarkTheme function parameters changed
By: Lance on Wed, 09 October 2024 23:39
|
 |
|
Re: DarkTheme function parameters changed
By: mirek on Wed, 13 November 2024 23:54
|
 |
|
Re: DarkTheme function parameters changed
By: Tom1 on Sat, 14 September 2024 23:18
|
Goto Forum:
Current Time: Sun Jun 08 15:22:32 CEST 2025
Total time taken to generate the page: 0.03417 seconds
|