Hi Mirek,

So far only thing I have noticed is that theide file tabs don't get updated when theme is changed.

EDIT: It would surely be nice to have two separate color palettes of user configurable syntax highlighting colors: One for light and one for dark mode(s). And also have the appropriate palette loaded automatically when theme is changed.

Hi Mirek,

Yes, now the tabs look right.

I think TheIDE would need "Ctrl::SkinChangeSensitive();" in main.cpp to properly follow "Host platform" selection automatically when theme changes.

Additionally, it would be nice to have just a minimal reference example for switching themes through a menu with following choices:

"Host platform (dynamic)"
"Host platform (forced dark)"
"Host platform (forced light)"
"Custom theme (static)"

The two middle choices, i.e.:

"Host platform (forced dark)"
"Host platform (forced light)"

are of interest on Windows due to the synthetic nature of dark mode there, but probably irrelevant on other platforms.

Thanks and best regards,

Tom

#include <CtrlLib/CtrlLib.h>

using namespace Upp;

struct MainWindow : public TopWindow{
	MenuBar menu;

	MainWindow() {
		Title("Dynamic Theming Sample").Sizeable();
		AddFrame(menu);
		menu.Set([=](Bar& bar) {
			bar.Sub("Theme",[=](Bar& bar) {
				bar.Add("Host platform (dynamic)",[=] { Ctrl::SkinChangeSensitive(true); SetDarkThemeEnabled(true); Ctrl::SetSkin(ChHostSkin); });
				bar.Add("Host platform (forced dark)",[=] { Ctrl::SkinChangeSensitive(false); SetDarkThemeEnabled(true); Ctrl::SetSkin(ChHostSkin); });
				bar.Add("Host platform (forced light)",[=] { Ctrl::SkinChangeSensitive(false); SetDarkThemeEnabled(false); Ctrl::SetSkin(ChHostSkin); });
				bar.Add("Custom theme (static)",[=] { Ctrl::SkinChangeSensitive(false); Ctrl::SetSkin(ChStdSkin); });
			});
		});
	}
	
};


GUI_APP_MAIN{
	Ctrl::SkinChangeSensitive(true);
	
	MainWindow().Run();
}

void Ctrl::SkinChangeSensitive(bool set){
	s_skin_change_sensitive = set;
}

Hi,

Another finding in theide: The color of the 'cross hairs' (one vertical and two horizontal) that show the caret location in the code editor are not updated when theme changes.

Best regards,

Tom

Tom1 wrote on Mon, 18 November 2024 22:04

Hi Mirek,

Yes, now the tabs look right.

I think TheIDE would need "Ctrl::SkinChangeSensitive();" in main.cpp to properly follow "Host platform" selection automatically when theme changes.

Additionally, it would be nice to have just a minimal reference example for switching themes through a menu with following choices:

"Host platform (dynamic)"
"Host platform (forced dark)"
"Host platform (forced light)"
"Custom theme (static)"

The two middle choices, i.e.:

"Host platform (forced dark)"
"Host platform (forced light)"

are of interest on Windows due to the synthetic nature of dark mode there, but probably irrelevant on other platforms.

Thanks and best regards,

Tom

Mirek,

I mean this is sort of example...

#include <CtrlLib/CtrlLib.h>

using namespace Upp;

struct MainWindow : public TopWindow{
	MenuBar menu;

	MainWindow() {
		Title("Dynamic Theming Sample").Sizeable();
		AddFrame(menu);
		menu.Set([=](Bar& bar) {
			bar.Sub("Theme",[=](Bar& bar) {
				bar.Add("Host platform (dynamic)",[=] { Ctrl::SkinChangeSensitive(true); SetDarkThemeEnabled(true); Ctrl::SetSkin(ChHostSkin); });
				bar.Add("Host platform (forced dark)",[=] { Ctrl::SkinChangeSensitive(false); SetDarkThemeEnabled(true); Ctrl::SetSkin(ChHostSkin); });
				bar.Add("Host platform (forced light)",[=] { Ctrl::SkinChangeSensitive(false); SetDarkThemeEnabled(false); Ctrl::SetSkin(ChHostSkin); });
				bar.Add("Custom theme (static)",[=] { Ctrl::SkinChangeSensitive(false); Ctrl::SetSkin(ChStdSkin); });
			});
		});
	}
	
};


GUI_APP_MAIN{
	Ctrl::SkinChangeSensitive(true);
	
	MainWindow().Run();
}

Additionally, this requires the following change:

void Ctrl::SkinChangeSensitive(bool set){
	s_skin_change_sensitive = set;
}

Best regards,

Tom

EDIT: Fixed sample code...

SetDarkThemeEnabled is now sort of deprecated, I am not going to change CtrlCore just because of single reference example and I think the reference example should demonstrate much more than this (Skin, SColor). But yep, it is coming.

Tom1 wrote on Tue, 19 November 2024 07:44

Hi,

Another finding in theide: The color of the 'cross hairs' (one vertical and two horizontal) that show the caret location in the code editor are not updated when theme changes.

Best regards,

Tom

Thank you, hopefully fixed, please keep testing.

mirek wrote on Tue, 19 November 2024 11:14

Tom1 wrote on Tue, 19 November 2024 07:44

Hi,

Another finding in theide: The color of the 'cross hairs' (one vertical and two horizontal) that show the caret location in the code editor are not updated when theme changes.

Best regards,

Tom

Thank you, hopefully fixed, please keep testing.

Thanks, it works fine now.

Maybe the "Settings/Editor/Paint line at column [96]" color setting should be automatically converted between light and dark modes. Depending on the user's color selection, the line may draw too much attention after theme change.

Best regards,

Tom

Tom1 wrote on Tue, 19 November 2024 14:22

mirek wrote on Tue, 19 November 2024 11:14

Tom1 wrote on Tue, 19 November 2024 07:44

Hi,

Another finding in theide: The color of the 'cross hairs' (one vertical and two horizontal) that show the caret location in the code editor are not updated when theme changes.

Best regards,

Tom

Thank you, hopefully fixed, please keep testing.

Thanks, it works fine now.

Maybe the "Settings/Editor/Paint line at column [96]" color setting should be automatically converted between light and dark modes. Depending on the user's color selection, the line may draw too much attention after theme change.

Best regards,

Tom

Not sure what you mean. If Custom colors is not active, it is changed according to the theme. If Custom colors is active, you would be changing color selected by user. Did I misundertood the request?

Oh, BTW, dark theme flip key in debug mode is now "Ctrl + Num[*]" (previously selected key was causing problems).

mirek wrote on Wed, 20 November 2024 11:29

Tom1 wrote on Tue, 19 November 2024 14:22

mirek wrote on Tue, 19 November 2024 11:14

Tom1 wrote on Tue, 19 November 2024 07:44

Hi,

Another finding in theide: The color of the 'cross hairs' (one vertical and two horizontal) that show the caret location in the code editor are not updated when theme changes.

Best regards,

Tom

Thank you, hopefully fixed, please keep testing.

Thanks, it works fine now.

Maybe the "Settings/Editor/Paint line at column [96]" color setting should be automatically converted between light and dark modes. Depending on the user's color selection, the line may draw too much attention after theme change.

Best regards,

Tom

Not sure what you mean. If Custom colors is not active, it is changed according to the theme. If Custom colors is active, you would be changing color selected by user. Did I misundertood the request?

Oh, BTW, dark theme flip key in debug mode is now "Ctrl + Num[*]" (previously selected key was causing problems).

I mean, there is a user selectable color available at: "Settings/Editor/Paint line at column [96]". Currently this is not changed along with theme, although it is visible in the editing area. This color is not set within "Syntax highlighting" either, so it is sort of a fixed color without theme dependence.

Just to test, change the "Settings/Editor/Paint line at column [96]" color to pure white and see how it disappears with light theme and is shown with high contrast on dark theme. I think it should be some way connected to the theme to keep it viewable with any theme while avoiding too much contrast.

Best regards,

Tom

Tom1 wrote on Wed, 20 November 2024 12:23

mirek wrote on Wed, 20 November 2024 11:29

Tom1 wrote on Tue, 19 November 2024 14:22

mirek wrote on Tue, 19 November 2024 11:14

Tom1 wrote on Tue, 19 November 2024 07:44

Hi,

Another finding in theide: The color of the 'cross hairs' (one vertical and two horizontal) that show the caret location in the code editor are not updated when theme changes.

Best regards,

Tom

Thank you, hopefully fixed, please keep testing.

Thanks, it works fine now.

Maybe the "Settings/Editor/Paint line at column [96]" color setting should be automatically converted between light and dark modes. Depending on the user's color selection, the line may draw too much attention after theme change.

Best regards,

Tom

Not sure what you mean. If Custom colors is not active, it is changed according to the theme. If Custom colors is active, you would be changing color selected by user. Did I misundertood the request?

Oh, BTW, dark theme flip key in debug mode is now "Ctrl + Num[*]" (previously selected key was causing problems).

I mean, there is a user selectable color available at: "Settings/Editor/Paint line at column [96]". Currently this is not changed along with theme, although it is visible in the editing area. This color is not set within "Syntax highlighting" either, so it is sort of a fixed color without theme dependence.

Just to test, change the "Settings/Editor/Paint line at column [96]" color to pure white and see how it disappears with light theme and is shown with high contrast on dark theme. I think it should be some way connected to the theme to keep it viewable with any theme while avoiding too much contrast.

Best regards,

Tom

If you change it to pure white, you have custom colors. Do you suggest to throw away user choices?

Mirek

mirek wrote on Wed, 20 November 2024 13:40

Tom1 wrote on Wed, 20 November 2024 12:23

mirek wrote on Wed, 20 November 2024 11:29

Tom1 wrote on Tue, 19 November 2024 14:22

mirek wrote on Tue, 19 November 2024 11:14

Tom1 wrote on Tue, 19 November 2024 07:44

Hi,

Another finding in theide: The color of the 'cross hairs' (one vertical and two horizontal) that show the caret location in the code editor are not updated when theme changes.

Best regards,

Tom

Thank you, hopefully fixed, please keep testing.

Thanks, it works fine now.

Maybe the "Settings/Editor/Paint line at column [96]" color setting should be automatically converted between light and dark modes. Depending on the user's color selection, the line may draw too much attention after theme change.

Best regards,

Tom

Not sure what you mean. If Custom colors is not active, it is changed according to the theme. If Custom colors is active, you would be changing color selected by user. Did I misundertood the request?

Oh, BTW, dark theme flip key in debug mode is now "Ctrl + Num[*]" (previously selected key was causing problems).

I mean, there is a user selectable color available at: "Settings/Editor/Paint line at column [96]". Currently this is not changed along with theme, although it is visible in the editing area. This color is not set within "Syntax highlighting" either, so it is sort of a fixed color without theme dependence.

Just to test, change the "Settings/Editor/Paint line at column [96]" color to pure white and see how it disappears with light theme and is shown with high contrast on dark theme. I think it should be some way connected to the theme to keep it viewable with any theme while avoiding too much contrast.

Best regards,

Tom

If you change it to pure white, you have custom colors. Do you suggest to throw away user choices?

Mirek

I do not think I first changed it at all, but I just observed its high contrast on one theme and low contrast on the other, when switching between light and dark on Windows. How do I reset it back to default to get it theme sensitive again?

BR, Tom

Tom1 wrote on Wed, 20 November 2024 12:57

mirek wrote on Wed, 20 November 2024 13:40

Tom1 wrote on Wed, 20 November 2024 12:23

mirek wrote on Wed, 20 November 2024 11:29

Tom1 wrote on Tue, 19 November 2024 14:22

mirek wrote on Tue, 19 November 2024 11:14

Tom1 wrote on Tue, 19 November 2024 07:44

Hi,

Another finding in theide: The color of the 'cross hairs' (one vertical and two horizontal) that show the caret location in the code editor are not updated when theme changes.

Best regards,

Tom

Thank you, hopefully fixed, please keep testing.

Thanks, it works fine now.

Maybe the "Settings/Editor/Paint line at column [96]" color setting should be automatically converted between light and dark modes. Depending on the user's color selection, the line may draw too much attention after theme change.

Best regards,

Tom

Not sure what you mean. If Custom colors is not active, it is changed according to the theme. If Custom colors is active, you would be changing color selected by user. Did I misundertood the request?

Oh, BTW, dark theme flip key in debug mode is now "Ctrl + Num[*]" (previously selected key was causing problems).

I mean, there is a user selectable color available at: "Settings/Editor/Paint line at column [96]". Currently this is not changed along with theme, although it is visible in the editing area. This color is not set within "Syntax highlighting" either, so it is sort of a fixed color without theme dependence.

Just to test, change the "Settings/Editor/Paint line at column [96]" color to pure white and see how it disappears with light theme and is shown with high contrast on dark theme. I think it should be some way connected to the theme to keep it viewable with any theme while avoiding too much contrast.

Best regards,

Tom

If you change it to pure white, you have custom colors. Do you suggest to throw away user choices?

Mirek

I do not think I first changed it at all, but I just observed its high contrast on one theme and low contrast on the other, when switching between light and dark on Windows. How do I reset it back to default to get it theme sensitive again?

BR, Tom

There is "Custom colors" option. If active, we do not touch editor colors on switch.

Of course, it is possible you have hit some cornercase. But when I am testing it, it looks fine...

Mirek

OK, finally figured out that I misunderstood which line we are talking about, should be now fixed...