Hi Mirek,

I stumbled over the changes in TabBar (I'm using it in my UppCad) and I've seen that the bug exists also in CancelCloseSome Gate, which doesn't work anymore as intended, and it's useless like it is now.

I guess it should be possible to add a "ConfirmCloseSome" gate, as for ConfirmClose, and remove the CancelCloseSome one.
The usage should be like ConfirmClose, but taking a number of tabs and not a single one.

Ciao

Massimo

EDIT: I wanted to fix it by myself, but I see that there's a complete mixing of old and new behaviour, with mistakes in many places.
Fixing it will be difficult... by now I'll take the old TabBar code from around 2016, which worked well.

In a reply to this post back in 2016

https://www.ultimatepp.org/forums/index.php?t=msg&th=966 7&start=0&

I and cbpporter were able to make it work. Will no longer.

So far this looks to be the right solution.

1. Take the old CancelClose method and assign it to ConfirmClose.
2. Rewrite the logic in the new ConfirmClose so that the return value bool is reversed.
3. Write a new CancelClose, this for one reason only: if you want to perpetuate the behavior of TabBar of not allowing you to close the last tab. This needs a bit further investigation. The new CancelClose is something very simple, like testing how many tabs you have open:

bool EditorManager::OnCancelClose(Value val) {
	int count = tabFiles.GetCount();
	return count <= 1;
}

I also removed the *Some variant of these callbacks, these needs further investigation if they are of use to me.

I'm doing a grounds up rewrite of one of the old UI projects as a refresh/modernization and I just arrived at the stage of adding TabCtrl.

Hopefully this time I can make sense of the Close variants and not occasionally still crash...

If not, I'll tell you my findings.

Might have to fork it though. We'll see...