U++ forum: Welcome to the forum

Re: Upp 2007.1rc4 released [message #8842 is a reply to message #8822]

Tue, 03 April 2007 07:41

fallingdutch
Messages: 258
Registered: July 2006

Experienced Member

Good Morning,

ebojd wrote on Mon, 02 April 2007 15:02

I pulled a bonehead yesterday when I wrote the upp-portage ebuild for rc4 and just removed the old rc3 before testing rc4... DOH.

Here is a patch for the top Makefile and some questions for the uppsrc/ide/Makefile.

*) is there a reason why pkg-config was not used in the uppsrc/ide/Makefile instead of hardcoding?

the uppsrc/ide/Makefile is a slightly changed Makefile which was generated by theide and theide hardcodes it.

ebojd wrote on Mon, 02 April 2007 15:02

Top level Makefile:

*) move all: before theide: -- if no arguments are given to make,
it will run the first one which is assumed to be all.

yes, sounds good.

ebojd wrote on Mon, 02 April 2007 15:02

*) added - infront of install so that it will deal appropriately
with files that already exist, etc.

what did you do? don't see the change in the patch either.

ebojd wrote on Mon, 02 April 2007 15:02

*) added trailing / to all install (cp -r *) lines. I do
not know where the bug is, but it will sometimes install
the files in a directory one above the destination.

yes, thought they have been there as you see the install lines.

ebojd wrote on Mon, 02 April 2007 15:02

*) remove clean from all -- because the "make all" and "make
install" are seperate.

ebojd wrote on Mon, 02 April 2007 15:02

*) added mkdir -p before copying Common and other files.
"cp -r Common /usr/share/upp" will not copy the Common
diretory into /usr/share/upp but it's contents.

yes sure makes sense

ebojd wrote on Mon, 02 April 2007 15:02

*) current Makefiles break gentoo's multithreaded make. I'll
have to investigate this one.

please do so, i would like the makefile to run on as many systems as possible

ebojd wrote on Mon, 02 April 2007 15:02

*) change $(DESTDIR)/usr/... to $(DESTDIR)/... -- if the DESTDIR
is set to usr, then everything is installed into /usr/usr.
Destdir should be set to something reasonable like /usr, /opt,
etc.

I am sorry, but that is impossible for me - the package builder asks for a $DESTDIR to create a temporary folder where the root directory is simulted to create the package.
Any Idea how to get around this are welcome!

ebojd wrote on Mon, 02 April 2007 15:02

I'm currently rebuilding upp (hopefully for the last time), but the folling patches should be helpful. I'll post the new upp-portage as soon as I know that it builds properly and pasts the QA tests.

The patch file should be attached.

Thank you a lot for your help, will apply all patches except the ones with $DESTDIR

Bas

Report message to a moderator