U++ forum: Welcome to the forum

Re: Heap-leaks and polymorphic containers [message #15864 is a reply to message #15858]

Tue, 13 May 2008 15:46

mrjt
Messages: 705
Registered: March 2007
Location: London

Contributor

luzr wrote on Mon, 12 May 2008 18:05

Well, virtual destructor is absolutely required here.

Hmm. I understand why this works (the implicit destructor isn't virtual):

struct Item : public Moveable<Item> {
	String name;
	
	virtual ~Item() { }	
};

struct Collection : public Item
{
	Array<Item> items;
};

GUI_APP_MAIN
{
	Collection *col = new Collection();
	col->items.Add();
	Item *item = (Item *)col;
	delete item;
}

But what baffles me is why this works with Vector, but not Array (the Array's destructor doesn't get called but the Vector one does).

struct Item : public Moveable<Item> {
	String name;	
};

struct Collection : public Item
{
	Vector<Item> items; // Heap leak if changed to Array
};

GUI_APP_MAIN
{
	Collection *col = new Collection();
	col->items.Add();
	Item *item = (Item *)col;
	delete item;
}

[Updated on: Tue, 13 May 2008 15:59]

Report message to a moderator