U++ forum: Welcome to the forum

Re: Upp 604-dev1 released [message #2384 is a reply to message #2379]

Mon, 10 April 2006 11:08

mirek
Messages: 14261
Registered: November 2005

Ultimate Member

hojtsy wrote on Mon, 10 April 2006 04:53

luzr wrote on Thu, 06 April 2006 17:50

Actually, it should be

inline void EndianSwap(word& v) { byte *x = (byte *)(&v); Swap(x[0], x[1]); }

Good that GCC catched that bug... (anyway, it is inactive for current U++)

The other 4 EndianSwap methods have the same error. I suppose they should also be corrected.

I hope they already are?

(BTW, another nice example of implementation defined code... Frankly, I would rather spend my energy here than with anticipating non-complement binary arithmetic, but resulting code for e.g. BMP header encoding/decoding would be much more ugly and complicated, even when we have to use packing pragmas....).

Mirek

Report message to a moderator