U++ forum: Welcome to the forum

Re: T* Detach() for ArrayMap [message #24881 is a reply to message #24874]

Tue, 02 February 2010 22:52

mirek
Messages: 14256
Registered: November 2005

Ultimate Member

kohait00 wrote on Tue, 02 February 2010 10:31

hi there

i ran into the need of

T* ArrayMap<K, T>::Detach(const K & key)

function. normal Array<T> *does* have one
T* Array<T>::Detach(int i);

since one can do a

T & Add(const K & key, T * newt)

on both, Array<T> and ArrayMap<K, T>, it would be consistent to have a Detach() function on both cotainer types.

so maybe the following lines could be added to Map.h

T* Detach(int i) { T *t = &B::value[i]; B::key.Remove(i); return t; }

Hm, is that correct implementation?

I would say something like

T* Detach(int i) { B::key.Remove(i); return B::value.Detach(i); }

is the correct one?

Another problem there is that this kind of detach is quite slow. Maybe we need DetachUnlink too (?).

Mirek

Report message to a moderator