U++ forum: Welcome to the forum

Re: Wrong(?) ASSERT in Vector<>::Insert() [message #27997 is a reply to message #27807]

Fri, 13 August 2010 09:34

mirek
Messages: 13984
Registered: November 2005

Ultimate Member

dolik.rce wrote on Wed, 04 August 2010 17:33

Hello,
I just hit a problem in Vector code and I feel a need for explanation Smile

. Have a look at this code

#include <Core/Core.h>
using namespace Upp;

CONSOLE_APP_MAIN{
	Vector<int> v;
	v.Add(123);
	v.Insert(0,v[0]);
}

It is classical and nasty bug.

Insert expects a reference, but at the same time invalidates references to v.

Not that in this particular case, we could workaround it in Vector code, but there are other similar cases where this is not quite possible:

http://www.ultimatepp.org/srcdoc$Core$Caveats$en-us.html

so I decided to forbid them all.

(And thanks kohait, you are 100% right).

And yes, I am not happy about this, but I guess ASSERT is best we can get here....

Report message to a moderator