U++ forum: Welcome to the forum

Re: LaunchWebBrowser() problem and perhaps not the best solution [message #35737 is a reply to message #35731]

Thu, 15 March 2012 08:41

koldo
Messages: 3437
Registered: August 2008

Senior Veteran

Hello Mirek

In fact WaitForSingleObject() is useless as it always wait the timeout.

However I realized that sometimes the string passed is released BEFORE the thread is really run so second call to ShellExecuteW() fails as LaunchWebBrowser() has ended before Smile

.

The proposed solution is this one:

void ShellExecuteOpen(char *str)
{
	ShellExecuteW(NULL, L"open", ToSystemCharsetW(str), NULL, L".", SW_SHOWDEFAULT);
	free((void *)str);
}

void LaunchWebBrowser(const String& url)
{
	if (int(ShellExecuteW(NULL, L"open", ToSystemCharsetW(url), NULL, L".", SW_SHOWDEFAULT)) <= 32) {
		char *curl = (char *)malloc(url.GetLength()+1);
		strcpy(curl, url);
		HANDLE handle = CreateThread(NULL, 0, (LPTHREAD_START_ROUTINE)&ShellExecuteOpen, (LPVOID)curl, 0, NULL);
		if (handle == NULL)
			return;
		CloseHandle(handle);
	} 
}

The thread receives the string and releases it.

Best regards
Iñaki

Report message to a moderator